Skip to content

Commit 12b6a9b

Browse files
deshipudeshipu
committed
Add qrio.QRDecoder.find() to locate codes without decoding
Fix adafruit#8452
1 parent 843fca1 commit 12b6a9b

5 files changed

Lines changed: 141 additions & 15 deletions

File tree

‎shared-bindings/qrio/QRDecoder.c‎

Lines changed: 41 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,19 @@ STATIC mp_obj_t qrio_qrdecoder_make_new(const mp_obj_type_t *type, size_t n_args
5656
return self;
5757
}
5858

59+
60+
STATIC void verify_buffer_size(qrio_qrdecoder_obj_t *self, mp_obj_t *buffer, size_t len, qrio_pixel_policy_t policy) {
61+
int width = shared_module_qrio_qrdecoder_get_width(self);
62+
int height = shared_module_qrio_qrdecoder_get_height(self);
63+
64+
// verify that the buffer is big enough
65+
int sz = width * height;
66+
if (policy != QRIO_EVERY_BYTE) {
67+
sz *= 2;
68+
}
69+
mp_get_index(mp_obj_get_type(*buffer), len, MP_OBJ_NEW_SMALL_INT(sz - 1), false);
70+
}
71+
5972
//| def decode(
6073
//| self, buffer: ReadableBuffer, pixel_policy: PixelPolicy = PixelPolicy.EVERY_BYTE
6174
//| ) -> List[QRInfo]:
@@ -73,22 +86,39 @@ STATIC mp_obj_t qrio_qrdecoder_decode(size_t n_args, const mp_obj_t *pos_args, m
7386

7487
mp_buffer_info_t bufinfo;
7588
mp_get_buffer_raise(args[ARG_buffer].u_obj, &bufinfo, MP_BUFFER_READ);
76-
77-
int width = shared_module_qrio_qrdecoder_get_width(self);
78-
int height = shared_module_qrio_qrdecoder_get_height(self);
79-
80-
// verify that the buffer is big enough
81-
int sz = width * height;
8289
qrio_pixel_policy_t policy = cp_enum_value(&qrio_pixel_policy_type, args[ARG_pixel_policy].u_obj, MP_QSTR_pixel_policy);
83-
if (policy != QRIO_EVERY_BYTE) {
84-
sz *= 2;
85-
}
86-
mp_get_index(mp_obj_get_type(args[ARG_buffer].u_obj), bufinfo.len, MP_OBJ_NEW_SMALL_INT(sz - 1), false);
90+
verify_buffer_size(self, &args[ARG_buffer].u_obj, bufinfo.len, policy);
8791

8892
return shared_module_qrio_qrdecoder_decode(self, &bufinfo, policy);
8993
}
9094
MP_DEFINE_CONST_FUN_OBJ_KW(qrio_qrdecoder_decode_obj, 1, qrio_qrdecoder_decode);
9195

96+
97+
//| def find(
98+
//| self, buffer: ReadableBuffer, pixel_policy: PixelPolicy = PixelPolicy.EVERY_BYTE
99+
//| ) -> List[QRPosition]:
100+
//| """Find all visible QR codes from the given image. The size of the buffer must be at least ``length``×``width`` bytes for `EVERY_BYTE`, and 2×``length``×``width`` bytes for `EVEN_BYTES` or `ODD_BYTES`."""
101+
STATIC mp_obj_t qrio_qrdecoder_find(size_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_args) {
102+
qrio_qrdecoder_obj_t *self = MP_OBJ_TO_PTR(pos_args[0]);
103+
104+
enum { ARG_buffer, ARG_pixel_policy };
105+
static const mp_arg_t allowed_args[] = {
106+
{ MP_QSTR_buffer, MP_ARG_OBJ | MP_ARG_REQUIRED, {.u_int = 0} },
107+
{ MP_QSTR_pixel_policy, MP_ARG_OBJ, {.u_obj = MP_ROM_PTR((mp_obj_t *)&qrio_pixel_policy_EVERY_BYTE_obj)} },
108+
};
109+
mp_arg_val_t args[MP_ARRAY_SIZE(allowed_args)];
110+
mp_arg_parse_all(n_args - 1, pos_args + 1, kw_args, MP_ARRAY_SIZE(allowed_args), allowed_args, args);
111+
112+
mp_buffer_info_t bufinfo;
113+
mp_get_buffer_raise(args[ARG_buffer].u_obj, &bufinfo, MP_BUFFER_READ);
114+
qrio_pixel_policy_t policy = cp_enum_value(&qrio_pixel_policy_type, args[ARG_pixel_policy].u_obj, MP_QSTR_pixel_policy);
115+
verify_buffer_size(self, &args[ARG_buffer].u_obj, bufinfo.len, policy);
116+
117+
return shared_module_qrio_qrdecoder_find(self, &bufinfo, policy);
118+
}
119+
MP_DEFINE_CONST_FUN_OBJ_KW(qrio_qrdecoder_find_obj, 1, qrio_qrdecoder_find);
120+
121+
92122
//| width: int
93123
//| """The width of image the decoder expects"""
94124
STATIC mp_obj_t qrio_qrdecoder_get_width(mp_obj_t self_in) {
@@ -135,6 +165,7 @@ STATIC const mp_rom_map_elem_t qrio_qrdecoder_locals_table[] = {
135165
{ MP_ROM_QSTR(MP_QSTR_width), MP_ROM_PTR(&qrio_qrdecoder_width_obj) },
136166
{ MP_ROM_QSTR(MP_QSTR_height), MP_ROM_PTR(&qrio_qrdecoder_height_obj) },
137167
{ MP_ROM_QSTR(MP_QSTR_decode), MP_ROM_PTR(&qrio_qrdecoder_decode_obj) },
168+
{ MP_ROM_QSTR(MP_QSTR_find), MP_ROM_PTR(&qrio_qrdecoder_find_obj) },
138169
};
139170

140171
STATIC MP_DEFINE_CONST_DICT(qrio_qrdecoder_locals, qrio_qrdecoder_locals_table);

‎shared-bindings/qrio/QRInfo.c‎

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,3 +63,66 @@ const mp_obj_namedtuple_type_t qrio_qrinfo_type_obj = {
6363
MP_QSTR_data_type,
6464
},
6565
};
66+
67+
//| class QRPosition:
68+
//| """Information about a non-decoded QR code"""
69+
//|
70+
//| top_left_x: int
71+
//| """X coordinate of the top left corner"""
72+
//|
73+
//| top_left_y: int
74+
//| """Y coordinate of the top left corner"""
75+
//|
76+
//| top_right_x: int
77+
//| """X coordinate of the top right corner"""
78+
//|
79+
//| top_right_y: int
80+
//| """Y coordinate of the top right corner"""
81+
//|
82+
//| bottom_right_x: int
83+
//| """X coordinate of the bottom right corner"""
84+
//|
85+
//| bottom_right_y: int
86+
//| """Y coordinate of the bottom right corner"""
87+
//|
88+
//| bottom_left_x: int
89+
//| """X coordinate of the bottom left corner"""
90+
//|
91+
//| bottom_left_y: int
92+
//| """Y coordinate of the bottom left corner"""
93+
//|
94+
//| size: int
95+
//| """The number of bits the code contains"""
96+
//|
97+
98+
const mp_obj_namedtuple_type_t qrio_qrposition_type_obj = {
99+
.base = {
100+
.base = {
101+
.type = &mp_type_type
102+
},
103+
.flags = MP_TYPE_FLAG_EXTENDED,
104+
.name = MP_QSTR_QRPosition,
105+
.print = namedtuple_print,
106+
.parent = &mp_type_tuple,
107+
.make_new = namedtuple_make_new,
108+
.attr = namedtuple_attr,
109+
MP_TYPE_EXTENDED_FIELDS(
110+
.unary_op = mp_obj_tuple_unary_op,
111+
.binary_op = mp_obj_tuple_binary_op,
112+
.subscr = mp_obj_tuple_subscr,
113+
.getiter = mp_obj_tuple_getiter,
114+
),
115+
},
116+
.n_fields = 9,
117+
.fields = {
118+
MP_QSTR_top_left_x,
119+
MP_QSTR_top_left_y,
120+
MP_QSTR_top_right_x,
121+
MP_QSTR_top_right_y,
122+
MP_QSTR_bottom_right_x,
123+
MP_QSTR_bottom_right_y,
124+
MP_QSTR_bottom_left_x,
125+
MP_QSTR_bottom_left_y,
126+
MP_QSTR_size,
127+
},
128+
};

‎shared-bindings/qrio/QRInfo.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,3 +29,4 @@
2929
#include "py/objnamedtuple.h"
3030

3131
extern const mp_obj_namedtuple_type_t qrio_qrinfo_type_obj;
32+
extern const mp_obj_namedtuple_type_t qrio_qrposition_type_obj;

‎shared-module/qrio/QRDecoder.c‎

Lines changed: 35 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,21 +98,21 @@ STATIC mp_obj_t data_type(int type) {
9898
return mp_obj_new_int(type);
9999
}
100100

101-
mp_obj_t shared_module_qrio_qrdecoder_decode(qrdecoder_qrdecoder_obj_t *self, const mp_buffer_info_t *bufinfo, qrio_pixel_policy_t policy) {
101+
STATIC void quirc_fill_buffer(qrdecoder_qrdecoder_obj_t *self, void *buf, qrio_pixel_policy_t policy) {
102102
int width, height;
103103
uint8_t *framebuffer = quirc_begin(self->quirc, &width, &height);
104-
uint8_t *src = bufinfo->buf;
104+
uint8_t *src = buf;
105105

106106
switch (policy) {
107107
case QRIO_RGB565: {
108-
uint16_t *src16 = bufinfo->buf;
108+
uint16_t *src16 = buf;
109109
for (int i = 0; i < width * height; i++) {
110110
framebuffer[i] = (src16[i] >> 3) & 0xfc;
111111
}
112112
break;
113113
}
114114
case QRIO_RGB565_SWAPPED: {
115-
uint16_t *src16 = bufinfo->buf;
115+
uint16_t *src16 = buf;
116116
for (int i = 0; i < width * height; i++) {
117117
framebuffer[i] = (__builtin_bswap16(src16[i]) >> 3) & 0xfc;
118118
}
@@ -133,19 +133,49 @@ mp_obj_t shared_module_qrio_qrdecoder_decode(qrdecoder_qrdecoder_obj_t *self, co
133133
break;
134134
}
135135
quirc_end(self->quirc);
136+
}
136137

138+
139+
mp_obj_t shared_module_qrio_qrdecoder_decode(qrdecoder_qrdecoder_obj_t *self, const mp_buffer_info_t *bufinfo, qrio_pixel_policy_t policy) {
140+
quirc_fill_buffer(self, bufinfo->buf, policy);
137141
int count = quirc_count(self->quirc);
138142
mp_obj_t result = mp_obj_new_list(0, NULL);
139143
for (int i = 0; i < count; i++) {
140144
quirc_extract(self->quirc, i, &self->code);
145+
mp_obj_t code_obj;
141146
if (quirc_decode(&self->code, &self->data) != QUIRC_SUCCESS) {
142147
continue;
143148
}
144149
mp_obj_t elems[2] = {
145150
mp_obj_new_bytes(self->data.payload, self->data.payload_len),
146151
data_type(self->data.data_type),
147152
};
148-
mp_obj_t code_obj = namedtuple_make_new((const mp_obj_type_t *)&qrio_qrinfo_type_obj, 2, 0, elems);
153+
code_obj = namedtuple_make_new((const mp_obj_type_t *)&qrio_qrinfo_type_obj, 2, 0, elems);
154+
mp_obj_list_append(result, code_obj);
155+
}
156+
return result;
157+
}
158+
159+
160+
mp_obj_t shared_module_qrio_qrdecoder_find(qrdecoder_qrdecoder_obj_t *self, const mp_buffer_info_t *bufinfo, qrio_pixel_policy_t policy) {
161+
quirc_fill_buffer(self, bufinfo->buf, policy);
162+
int count = quirc_count(self->quirc);
163+
mp_obj_t result = mp_obj_new_list(0, NULL);
164+
for (int i = 0; i < count; i++) {
165+
quirc_extract(self->quirc, i, &self->code);
166+
mp_obj_t code_obj;
167+
mp_obj_t elems[9] = {
168+
mp_obj_new_int(self->code.corners[0].x),
169+
mp_obj_new_int(self->code.corners[0].y),
170+
mp_obj_new_int(self->code.corners[1].x),
171+
mp_obj_new_int(self->code.corners[1].y),
172+
mp_obj_new_int(self->code.corners[2].x),
173+
mp_obj_new_int(self->code.corners[2].y),
174+
mp_obj_new_int(self->code.corners[3].x),
175+
mp_obj_new_int(self->code.corners[3].y),
176+
mp_obj_new_int(self->code.size),
177+
};
178+
code_obj = namedtuple_make_new((const mp_obj_type_t *)&qrio_qrposition_type_obj, 9, 0, elems);
149179
mp_obj_list_append(result, code_obj);
150180
}
151181
return result;

‎shared-module/qrio/QRDecoder.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,4 @@ int shared_module_qrio_qrdecoder_get_width(qrdecoder_qrdecoder_obj_t *);
4343
void shared_module_qrio_qrdecoder_set_height(qrdecoder_qrdecoder_obj_t *, int height);
4444
void shared_module_qrio_qrdecoder_set_width(qrdecoder_qrdecoder_obj_t *, int width);
4545
mp_obj_t shared_module_qrio_qrdecoder_decode(qrdecoder_qrdecoder_obj_t *, const mp_buffer_info_t *bufinfo, qrio_pixel_policy_t policy);
46+
mp_obj_t shared_module_qrio_qrdecoder_find(qrdecoder_qrdecoder_obj_t *, const mp_buffer_info_t *bufinfo, qrio_pixel_policy_t policy);

0 commit comments

Comments
 (0)