Fixed form validation with Django - closes pgvector#21

ankane · ankane · commit 5611b36c2bb6 · 2023-07-23T09:12:03.000-07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 ## 0.2.0 (unreleased)
 
+- Fixed form validation with Django
 - Dropped support for Python < 3.8
 
 ## 0.1.8 (2023-05-20)
diff --git a/pgvector/django/__init__.py b/pgvector/django/__init__.py
@@ -42,6 +42,12 @@ def get_prep_value(self, value):
     def value_to_string(self, obj):
         return self.get_prep_value(self.value_from_object(obj))
 
+    def validate(self, value, model_instance):
+        super().validate(value.tolist(), model_instance)
+
+    def run_validators(self, value):
+        super().run_validators(value.tolist())
+
 
 class IvfflatIndex(PostgresIndex):
     suffix = 'ivfflat'
diff --git a/tests/test_django.py b/tests/test_django.py
@@ -3,6 +3,7 @@
 from django.core import serializers
 from django.db import connection, migrations, models
 from django.db.migrations.loader import MigrationLoader
+from django.forms import ModelForm
 from math import sqrt
 import numpy as np
 import pgvector.django
@@ -79,6 +80,12 @@ def create_items():
         item.save()
 
 
+class ItemForm(ModelForm):
+    class Meta:
+        model = Item
+        fields = ['embedding']
+
+
 class TestDjango:
     def setup_method(self, test_method):
         Item.objects.all().delete()
@@ -127,3 +134,7 @@ def test_serialization(self):
                 get_model.return_value = Item
                 for obj in serializers.deserialize(format, data):
                     obj.save()
+
+    def test_form(self):
+        form = ItemForm(data={'embedding': [1, 2, 3]})
+        assert form.is_valid()
