From 9dc6a5373f1369e8099fb9602c08417a7d4fdb47 Mon Sep 17 00:00:00 2001 From: Rebecca Alpert Date: Mon, 15 Jun 2026 10:02:40 -0400 Subject: [PATCH] fix(EyeIcon): Replace EyeIcon with RhUiViewFillIcon Co-authored-by: Cursor --- .../src/components/LoginPage/LoginForm.tsx | 4 ++-- .../__snapshots__/LoginForm.test.tsx.snap | 20 ++++--------------- .../PasswordGenerator/PasswordGenerator.md | 2 +- .../examples/PasswordGenerator.tsx | 4 ++-- 4 files changed, 9 insertions(+), 21 deletions(-) diff --git a/packages/react-core/src/components/LoginPage/LoginForm.tsx b/packages/react-core/src/components/LoginPage/LoginForm.tsx index 821f6b6ef0e..d9257d9f2f2 100644 --- a/packages/react-core/src/components/LoginPage/LoginForm.tsx +++ b/packages/react-core/src/components/LoginPage/LoginForm.tsx @@ -5,8 +5,8 @@ import { Button } from '../Button'; import { Checkbox } from '../Checkbox'; import { ValidatedOptions } from '../../helpers/constants'; import { InputGroup, InputGroupItem } from '../InputGroup'; +import RhUiViewFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-view-fill-icon'; import EyeSlashIcon from '@patternfly/react-icons/dist/esm/icons/eye-slash-icon'; -import EyeIcon from '@patternfly/react-icons/dist/esm/icons/eye-icon'; import { HelperText, HelperTextItem } from '../HelperText'; export interface LoginFormProps extends Omit, 'ref'> { @@ -130,7 +130,7 @@ export const LoginForm: React.FunctionComponent = ({ variant="control" onClick={() => setPasswordHidden(!passwordHidden)} aria-label={passwordHidden ? showPasswordAriaLabel : hidePasswordAriaLabel} - icon={passwordHidden ? : } + icon={passwordHidden ? : } /> diff --git a/packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginForm.test.tsx.snap b/packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginForm.test.tsx.snap index fa88c11b905..5e65475b475 100644 --- a/packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginForm.test.tsx.snap +++ b/packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginForm.test.tsx.snap @@ -269,24 +269,12 @@ exports[`LoginForm LoginForm with show password 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 32 32" width="1em" > - - - - - - + diff --git a/packages/react-core/src/demos/PasswordGenerator/PasswordGenerator.md b/packages/react-core/src/demos/PasswordGenerator/PasswordGenerator.md index c859ae2ee43..334e640b262 100644 --- a/packages/react-core/src/demos/PasswordGenerator/PasswordGenerator.md +++ b/packages/react-core/src/demos/PasswordGenerator/PasswordGenerator.md @@ -5,7 +5,7 @@ section: patterns import { useEffect, useRef, useState } from 'react'; import RedoIcon from '@patternfly/react-icons/dist/esm/icons/redo-icon'; -import EyeIcon from '@patternfly/react-icons/dist/esm/icons/eye-icon'; +import RhUiViewFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-view-fill-icon'; import EyeSlashIcon from '@patternfly/react-icons/dist/esm/icons/eye-slash-icon'; ## Demos diff --git a/packages/react-core/src/demos/PasswordGenerator/examples/PasswordGenerator.tsx b/packages/react-core/src/demos/PasswordGenerator/examples/PasswordGenerator.tsx index 7eacc716e17..80466b662a7 100644 --- a/packages/react-core/src/demos/PasswordGenerator/examples/PasswordGenerator.tsx +++ b/packages/react-core/src/demos/PasswordGenerator/examples/PasswordGenerator.tsx @@ -12,7 +12,7 @@ import { MenuItemAction } from '@patternfly/react-core'; import RedoIcon from '@patternfly/react-icons/dist/esm/icons/redo-icon'; -import EyeIcon from '@patternfly/react-icons/dist/esm/icons/eye-icon'; +import RhUiViewFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-view-fill-icon'; import EyeSlashIcon from '@patternfly/react-icons/dist/esm/icons/eye-slash-icon'; export const PasswordGenerator: React.FunctionComponent = () => { @@ -123,7 +123,7 @@ export const PasswordGenerator: React.FunctionComponent = () => { variant="control" onClick={() => setPasswordHidden(!passwordHidden)} aria-label={passwordHidden ? 'Show password' : 'Hide password'} - icon={passwordHidden ? : } + icon={passwordHidden ? : } />