Stop printing two minus signs in fractional for a negative mixed number (python-humanize#320)

c-tonneslan · web-flow · commit c2c410c1521a · 2026-06-25T23:38:22.000+03:00
Signed-off-by: Charlie Tonneslan &lt;cst0520@gmail.com&gt;
diff --git a/src/humanize/number.py b/src/humanize/number.py
@@ -367,7 +367,12 @@ def fractional(value: NumberOrString) -> str:
     if not whole_number:
         return f"{numerator:.0f}/{denominator:.0f}"
 
-    return f"{whole_number:.0f} {numerator:.0f}/{denominator:.0f}"
+    # int() truncates toward zero, so for a negative number both
+    # whole_number and numerator carry the minus sign, which prints as
+    # "-1 -3/10". The sign already rides on the whole part; absorb it
+    # from the fractional part so the result reads as a normal mixed
+    # fraction.
+    return f"{whole_number:.0f} {abs(numerator):.0f}/{denominator:.0f}"
 
 
 def scientific(value: NumberOrString, precision: int = 2) -> str:
diff --git a/tests/test_number.py b/tests/test_number.py
@@ -183,6 +183,9 @@ def test_apnumber(test_input: int | str, expected: str) -> None:
         (-math.inf, "-Inf"),
         ("nan", "NaN"),
         ("-inf", "-Inf"),
+        (-1.3, "-1 3/10"),
+        (-2.5, "-2 1/2"),
+        (-0.5, "-1/2"),
     ],
 )
 def test_fractional(test_input: float | str, expected: str) -> None:
