Skip to content

Commit 1e1d858

Browse files
chore(internal): make test_proxy_environment_variables more resilient to env
1 parent d3ba149 commit 1e1d858

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

tests/test_client.py

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -961,8 +961,14 @@ def retry_handler(_request: httpx.Request) -> httpx.Response:
961961
def test_proxy_environment_variables(self, monkeypatch: pytest.MonkeyPatch) -> None:
962962
# Test that the proxy environment variables are set correctly
963963
monkeypatch.setenv("HTTPS_PROXY", "https://example.org")
964-
# Delete in case our environment has this set
964+
# Delete in case our environment has any proxy env vars set
965965
monkeypatch.delenv("HTTP_PROXY", raising=False)
966+
monkeypatch.delenv("ALL_PROXY", raising=False)
967+
monkeypatch.delenv("NO_PROXY", raising=False)
968+
monkeypatch.delenv("http_proxy", raising=False)
969+
monkeypatch.delenv("https_proxy", raising=False)
970+
monkeypatch.delenv("all_proxy", raising=False)
971+
monkeypatch.delenv("no_proxy", raising=False)
966972

967973
client = DefaultHttpxClient()
968974

@@ -1883,8 +1889,14 @@ async def test_get_platform(self) -> None:
18831889
async def test_proxy_environment_variables(self, monkeypatch: pytest.MonkeyPatch) -> None:
18841890
# Test that the proxy environment variables are set correctly
18851891
monkeypatch.setenv("HTTPS_PROXY", "https://example.org")
1886-
# Delete in case our environment has this set
1892+
# Delete in case our environment has any proxy env vars set
18871893
monkeypatch.delenv("HTTP_PROXY", raising=False)
1894+
monkeypatch.delenv("ALL_PROXY", raising=False)
1895+
monkeypatch.delenv("NO_PROXY", raising=False)
1896+
monkeypatch.delenv("http_proxy", raising=False)
1897+
monkeypatch.delenv("https_proxy", raising=False)
1898+
monkeypatch.delenv("all_proxy", raising=False)
1899+
monkeypatch.delenv("no_proxy", raising=False)
18881900

18891901
client = DefaultAsyncHttpxClient()
18901902

0 commit comments

Comments
 (0)