session: un-noop disconnect

enkore · enkore · commit 2ead93d2dcff · 2024-07-09T11:25:54.000+02:00
diff --git a/ssh/session.pyx b/ssh/session.pyx
@@ -140,15 +140,14 @@ cdef class Session:
         return handle_error_codes(rc, self._session)
 
     def disconnect(self):
-        """No-op. Handled by object de-allocation."""
-        # Due to bug in libssh that segfaults if session
-        # is disconnected before freeing channels spawned
-        # by that session - even if channels are closed.
-        pass
-        # if not c_ssh.ssh_is_connected(self._session):
-        #     return
-        # with nogil:
-        #     c_ssh.ssh_disconnect(self._session)
+        """
+        Cleanly disconnect connection. All channels left open at this point are invalidated.
+        Interacting with their Channel objects will trigger UB.
+        """
+        if not c_ssh.ssh_is_connected(self._session):
+            return
+        with nogil:
+            c_ssh.ssh_disconnect(self._session)
 
     def connector_new(self):
         cdef c_ssh.ssh_connector _connector
