Status bar with interpreter information takes priority over other items (microsoft#2618)

DonJayamanne · web-flow · commit ae155b3757a9 · 2018-09-18T13:40:35.000-07:00
Fixes microsoft#2617
diff --git a/news/1 Enhancements/2617.md b/news/1 Enhancements/2617.md
@@ -0,0 +1 @@
+Ensure status bar with interpreter information takes priority over other items.
diff --git a/src/client/interpreter/display/index.ts b/src/client/interpreter/display/index.ts
@@ -23,7 +23,7 @@ export class InterpreterDisplay implements IInterpreterDisplay {
         const application = serviceContainer.get<IApplicationShell>(IApplicationShell);
         const disposableRegistry = serviceContainer.get<Disposable[]>(IDisposableRegistry);
 
-        this.statusBar = application.createStatusBarItem(StatusBarAlignment.Left);
+        this.statusBar = application.createStatusBarItem(StatusBarAlignment.Left, 100);
         this.statusBar.command = 'python.setInterpreter';
         disposableRegistry.push(this.statusBar);
     }
diff --git a/src/test/interpreters/display.unit.test.ts b/src/test/interpreters/display.unit.test.ts
@@ -64,7 +64,7 @@ suite('Interpreters Display', () => {
         serviceContainer.setup(c => c.get(TypeMoq.It.isValue(IInterpreterHelper))).returns(() => interpreterHelper.object);
         serviceContainer.setup(c => c.get(TypeMoq.It.isValue(IPathUtils))).returns(() => pathUtils.object);
 
-        applicationShell.setup(a => a.createStatusBarItem(TypeMoq.It.isValue(StatusBarAlignment.Left), TypeMoq.It.isValue(undefined))).returns(() => statusBar.object);
+        applicationShell.setup(a => a.createStatusBarItem(TypeMoq.It.isValue(StatusBarAlignment.Left), TypeMoq.It.isValue(100))).returns(() => statusBar.object);
         pathUtils.setup(p => p.getDisplayName(TypeMoq.It.isAny(), TypeMoq.It.isAny())).returns(p => p);
 
         interpreterDisplay = new InterpreterDisplay(serviceContainer.object);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Ensure status bar with interpreter information takes priority over other items.`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ export class InterpreterDisplay implements IInterpreterDisplay {`
`23`	`23`	`const application = serviceContainer.get<IApplicationShell>(IApplicationShell);`
`24`	`24`	`const disposableRegistry = serviceContainer.get<Disposable[]>(IDisposableRegistry);`
`25`	`25`
`26`		`- this.statusBar = application.createStatusBarItem(StatusBarAlignment.Left);`
	`26`	`+ this.statusBar = application.createStatusBarItem(StatusBarAlignment.Left, 100);`
`27`	`27`	`this.statusBar.command = 'python.setInterpreter';`
`28`	`28`	`disposableRegistry.push(this.statusBar);`
`29`	`29`	`}`