Added file filter for drag & drop functionality.#29
Merged
Conversation
Bug fixed: If modified then ask to save the changes before drop a file.
Owner
|
Looks amazing 💯 @SidaDan!! |
pH-7
reviewed
Oct 22, 2018
| fis.close(); | ||
| } | ||
| catch (Exception ex) { | ||
| String[] extensionFilter = {".txt", ".dat", ".log", ".xml", ".mf", ".html"}; // allowed file filter extentions for drag and drop |
Owner
There was a problem hiding this comment.
Can this array be a class attribute instead? We might have to reuse it later on elsewhere in the class... (and easier to find it if we have to add more file extensions). What do you think?
Contributor
Author
There was a problem hiding this comment.
Hi. yes of course. Is only an example. You can create a setup.class as well.
Have a nice day
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
I added a file filter for drag & drop functionality and fixed a little bug
Bug fixed: If modified then ask to save the changes before drop a file.
Have a nice day.