Fix ExampleLibrary build errors in certain code pages (#1890)

myd7349 · web-flow · commit a7770d320e4b · 2022-08-14T08:52:33.000+01:00
Currently, these three files have an ANSI encoding:

- Source/Examples/ExampleLibrary/Annotations/ArrowAnnotationExamples.cs
- Source/Examples/ExampleLibrary/Annotations/TextAnnotationExamples.cs
- Source/Examples/ExampleLibrary/Examples/RenderingCapabilities.cs

which will cause build errors in certain code pages.

For example, in iso-8851-1 and cp936, degree symbol is not the same:

&gt;&gt;&gt; '°'.encode('iso-8859-1')
b'\xb0'
&gt;&gt;&gt; '°'.encode('cp936')
b'\xa1\xe3'

and when it comes to cp936, it can not understand '0xb0' correctly.

Solution:
Change encoding of these three files from ANSI to UTF-8 with BOM.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -27,6 +27,7 @@ All notable changes to this project will be documented in this file.
 - Axes not always honoring AbsoluteMinimum/AbsoluteMaximum and/or MinimumRange/MaximumRange properties (#1812)
 - WindowsForms tracker no longer clipping outside PlotView boundaries (#1863)
 - Histogram now rendering properly when using logarithmic Y axis (#740) 
+- Fix ExampleLibrary build errors in certain code pages (#1890)
 
 ## [2.1.0] - 2021-10-02
 
diff --git a/CONTRIBUTORS b/CONTRIBUTORS
@@ -102,6 +102,7 @@ moes_leco
 moljac
 mroth
 mrtncls
+myd7349 <myd7349@gmail.com>
 Oleg Tarasov <oleg.v.tarasov@gmail.com>
 Oystein Bjorke <oystein.bjorke@gmail.com>
 Patrice Marin <patrice.marin@thomsonreuters.com>
diff --git a/Source/Examples/ExampleLibrary/Annotations/ArrowAnnotationExamples.cs b/Source/Examples/ExampleLibrary/Annotations/ArrowAnnotationExamples.cs
@@ -1,4 +1,4 @@
-// --------------------------------------------------------------------------------------------------------------------
+﻿// --------------------------------------------------------------------------------------------------------------------
 // <copyright file="ArrowAnnotationExamples.cs" company="OxyPlot">
 //   Copyright (c) 2014 OxyPlot contributors
 // </copyright>
@@ -85,7 +85,7 @@ public static PlotModel Rotations()
                     new ArrowAnnotation
                         {
                             EndPoint = new DataPoint(i % 45, i / 45),
-                            Text = $"{i}�",
+                            Text = $"{i}°",
                             ArrowDirection = new ScreenVector(Math.Cos(rad), Math.Sin(rad)) * 25,
                             HeadLength = 5
                         });
diff --git a/Source/Examples/ExampleLibrary/Annotations/TextAnnotationExamples.cs b/Source/Examples/ExampleLibrary/Annotations/TextAnnotationExamples.cs
@@ -1,4 +1,4 @@
-// --------------------------------------------------------------------------------------------------------------------
+﻿// --------------------------------------------------------------------------------------------------------------------
 // <copyright file="TextAnnotationExamples.cs" company="OxyPlot">
 //   Copyright (c) 2014 OxyPlot contributors
 // </copyright>
@@ -74,7 +74,7 @@ public static PlotModel Rotations()
                                           {
                                               TextRotation = i, 
                                               TextPosition = new DataPoint(i % 45, i / 45), 
-                                              Text = $"{i}�", 
+                                              Text = $"{i}°", 
                                               TextVerticalAlignment = VerticalAlignment.Middle, 
                                               TextHorizontalAlignment = HorizontalAlignment.Center
                                           });
diff --git a/Source/Examples/ExampleLibrary/Examples/RenderingCapabilities.cs b/Source/Examples/ExampleLibrary/Examples/RenderingCapabilities.cs
@@ -1,4 +1,4 @@
-// --------------------------------------------------------------------------------------------------------------------
+﻿// --------------------------------------------------------------------------------------------------------------------
 // <copyright file="RenderingCapabilities.cs" company="OxyPlot">
 //   Copyright (c) 2014 OxyPlot contributors
 // </copyright>
@@ -805,7 +805,7 @@ public static PlotModel LineJoins()
                     var dy = Math.Cos(halfAngle) * LINE_LENGTH;
 
                     var textP = new ScreenPoint(15, y);
-                    rc.DrawText(textP, angle.ToString() + "�", OxyColors.Black, fontSize: 12);
+                    rc.DrawText(textP, angle.ToString() + "°", OxyColors.Black, fontSize: 12);
 
                     foreach (LineJoin lineJoin in Enum.GetValues(typeof(LineJoin)))
                     {
