Skip to content

Commit 6a0ec9e

Browse files
committed
Update contributing file
1 parent 52661df commit 6a0ec9e

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

.github/CONTRIBUTING.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ Note that your contributions must be your own work and licensed under the same t
1616
## Reporting bugs
1717

1818
First, search the issue tracker to see if the bug is already there.
19-
Please use the [discussion forums](https://oxyplot.userecho.com/) if you are unsure whether it is a bug in the library or a problem in your code.
20-
When you are sure, please add defects in the issue tracker.
2119

2220
It is very helpful to get the generated code (use `CTRL+ALT+C` in the plot control) and report (`CTRL+ALT+R`) of the bug plot. You can also take a screen shot and paste it into the description.
2321

@@ -36,8 +34,9 @@ A bug report should include:
3634

3735
## Suggesting new features
3836

39-
Please use the [discussion forums](https://oxyplot.userecho.com/) or add it directly in the issue tracker in the same way as bug reports.
37+
First, search the issue tracker to see if the feature is already there.
4038

39+
Wait for some feedback before starting to work on something that might not be merged in the end.
4140

4241
## Create your own fork
4342

@@ -96,26 +95,25 @@ Finally, push your commits: `git push`
9695

9796
## Requirements for a pull request
9897

98+
- Include the issue number
9999
- Include examples or unit tests for the change / new feature
100100
- Update the CHANGELOG.md file
101101
- Update the CONTRIBUTORS and AUTHORS files if you are not already listed there
102-
- Commits are rebased and squashed
103102

104103

105104
## Creating a pull request
106105

107106
- Open the GitHub page for your fork and create a "Pull Request" (PR)
108-
- Include the issue number in the pull request *comment* (not in the *title* where it will not be linked!)
109107

110108

111109
## Merging
112110

113-
When the PR is submitted, Appveyor will build the code and report if the build was successful.
111+
When the PR is submitted, a build will automatically be trigged.
114112
A team member will then review the PR, and merge the branch if everything looks OK.
115113

116-
If there are some issues with the PR, you must
114+
If there are some issues with the PR, you should
117115
- update your code and commit changes
118-
- rebase and squash again
116+
- clean up the git history with rebase or squash
119117
- force push: `git push -f`
120118

121119
The PR will be updated automatically when you push your changes.

0 commit comments

Comments
 (0)