Skip clojure.lang.DynamicClassLoader

sattvik · sattvik · commit 4953a6c41751 · 2019-02-04T07:12:29.000-06:00
Not doing this seems to cause issues with Clojure protocols.
An application instrumented with the dd-java-agent that will
otherwise run fine will fail with ClassNotFoundException for
classes pertaining to Clojure protocols.
diff --git a/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/ClassLoaderMatcher.java b/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/ClassLoaderMatcher.java
@@ -52,6 +52,7 @@ private static class SkipClassLoaderMatcher
       classesToSkip.add("org.codehaus.groovy.runtime.callsite.CallSiteClassLoader");
       classesToSkip.add("sun.reflect.DelegatingClassLoader");
       classesToSkip.add("jdk.internal.reflect.DelegatingClassLoader");
+      classesToSkip.add("clojure.lang.DynamicClassLoader");
       classesToSkip.add(DatadogClassLoader.class.getName());
       CLASSLOADER_CLASSES_TO_SKIP = Collections.unmodifiableSet(classesToSkip);
     }

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ private static class SkipClassLoaderMatcher`
`52`	`52`	`classesToSkip.add("org.codehaus.groovy.runtime.callsite.CallSiteClassLoader");`
`53`	`53`	`classesToSkip.add("sun.reflect.DelegatingClassLoader");`
`54`	`54`	`classesToSkip.add("jdk.internal.reflect.DelegatingClassLoader");`
	`55`	`+ classesToSkip.add("clojure.lang.DynamicClassLoader");`
`55`	`56`	`classesToSkip.add(DatadogClassLoader.class.getName());`
`56`	`57`	`CLASSLOADER_CLASSES_TO_SKIP = Collections.unmodifiableSet(classesToSkip);`
`57`	`58`	`}`