comparison between pointer and zero is not portable + avoids pedantic warning with clang++

Dane Springmeyer · Dane Springmeyer · commit fe6e76de683f · 2012-11-06T20:50:19.000Z
diff --git a/output-pgsql.c b/output-pgsql.c
@@ -188,8 +188,8 @@ void read_style_file( const char *filename )
             exit_nicely();
         }
     }
-    if ((temp.flags!=FLAG_DELETE) && ((strchr(temp.name,'?') >0) || (strchr(temp.name,'*') >0))) {
-        fprintf( stderr, "wildcard '%s' in non-delete style emtry\n",temp.name);
+    if ((temp.flags!=FLAG_DELETE) && ((strchr(temp.name,'?') != NULL) || (strchr(temp.name,'*') != NULL))) {
+        fprintf( stderr, "wildcard '%s' in non-delete style entry\n",temp.name);
         exit_nicely();
     }
     

Original file line number	Diff line number	Diff line change
`@@ -188,8 +188,8 @@ void read_style_file( const char *filename )`
`188`	`188`	`exit_nicely();`
`189`	`189`	`}`
`190`	`190`	`}`
`191`		`- if ((temp.flags!=FLAG_DELETE) && ((strchr(temp.name,'?') >0) \|\| (strchr(temp.name,'*') >0))) {`
`192`		`- fprintf( stderr, "wildcard '%s' in non-delete style emtry\n",temp.name);`
	`191`	`+ if ((temp.flags!=FLAG_DELETE) && ((strchr(temp.name,'?') != NULL) \|\| (strchr(temp.name,'*') != NULL))) {`
	`192`	`+ fprintf( stderr, "wildcard '%s' in non-delete style entry\n",temp.name);`
`193`	`193`	`exit_nicely();`
`194`	`194`	`}`
`195`	`195`