CMake config: Disable warnings triggered by Osmium behaviour in GCC

joto · joto · commit e859679c3e08 · 2026-02-05T12:02:06.000+01:00
Nothing we can do about these false-positives.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -165,7 +165,6 @@ jobs:
     env:
       CC: gcc-12
       CXX: g++-12
-      EXTRA_FLAGS: -Wno-stringop-overread
       LUA_VERSION: 5.3
       LUAJIT_OPTION: ON
       POSTGRESQL_VERSION: 13
@@ -262,7 +261,6 @@ jobs:
     env:
       CC: gcc-12
       CXX: g++-12
-      EXTRA_FLAGS: -Wno-stringop-overread
       LUA_VERSION: 5.4
       LUAJIT_OPTION: ON
       POSTGRESQL_VERSION: 16
diff --git a/.github/workflows/test-install.yml b/.github/workflows/test-install.yml
@@ -22,7 +22,7 @@ jobs:
       POSTGRESQL_VERSION: 16
       POSTGIS_VERSION: 3
       BUILD_TYPE: Release
-      CXXFLAGS: -pedantic -Wextra -Wno-stringop-overread -Werror
+      CXXFLAGS: -pedantic -Wextra -Werror
       PREFIX: /usr/local
       OSMURL: https://download.geofabrik.de/europe/monaco-latest.osm.pbf
       OSMFILE: monaco-latest.osm.pbf
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -52,6 +52,10 @@ else()
     add_compile_options(-Wall)
 endif()
 
+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+    add_definitions(-Wno-stringop-overread -Wno-maybe-uninitialized)
+endif()
+
 option(EXTERNAL_LIBOSMIUM "Do not use the bundled libosmium" OFF)
 option(EXTERNAL_PROTOZERO "Do not use the bundled protozero" OFF)
 option(EXTERNAL_FMT       "Do not use the bundled fmt"       OFF)
