Miscellaneous small cleanups

joto · joto · commit e7f48852a0df · 2023-02-27T07:34:48.000+01:00
diff --git a/src/flex-lua-table.cpp b/src/flex-lua-table.cpp
@@ -207,9 +207,9 @@ static void parse_and_set_expire_options(lua_State *lua_state,
 
     if (type == LUA_TUSERDATA) {
         auto const eo = idx_from_userdata(lua_state, -1, expire_outputs_size);
-        expire_config_t config{eo};
         // Actually add the expire only if we are in append mode.
         if (append_mode) {
+            expire_config_t const config{eo};
             column->add_expire(config);
         }
         return;
diff --git a/src/logging.cpp b/src/logging.cpp
@@ -43,7 +43,7 @@ std::string logger::generate_common_prefix(fmt::text_style const &ts,
     return str;
 }
 
-void logger::init_thread(unsigned int num) const
+void logger::init_thread(unsigned int num)
 {
     // Store thread number in thread local variable
     this_thread_num = num;
diff --git a/src/logging.hpp b/src/logging.hpp
@@ -79,7 +79,7 @@ class logger
     void needs_leading_return() noexcept { m_needs_leading_return = true; }
     void no_leading_return() noexcept { m_needs_leading_return = false; }
 
-    void init_thread(unsigned int num) const;
+    static void init_thread(unsigned int num);
 
 private:
     std::string generate_common_prefix(fmt::text_style const &ts,
diff --git a/src/output-flex.cpp b/src/output-flex.cpp
@@ -1264,7 +1264,7 @@ create_expire_tables(std::vector<expire_output_t> const &expire_outputs,
         return;
     }
 
-    pg_conn_t connection{conninfo};
+    pg_conn_t const connection{conninfo};
     connection.exec("SET client_min_messages = WARNING");
     for (auto &expire_output : expire_outputs) {
         if (!expire_output.table().empty()) {
diff --git a/src/wkb.cpp b/src/wkb.cpp
@@ -307,7 +307,7 @@ class make_ewkb_visitor
 class ewkb_parser_t
 {
 public:
-    ewkb_parser_t(std::string_view input)
+    explicit ewkb_parser_t(std::string_view input)
     : m_data(input),
       m_max_length(static_cast<uint32_t>(input.size()) / (sizeof(double) * 2))
     {}

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ std::string logger::generate_common_prefix(fmt::text_style const &ts,`
`43`	`43`	`return str;`
`44`	`44`	`}`
`45`	`45`
`46`		`-void logger::init_thread(unsigned int num) const`
	`46`	`+void logger::init_thread(unsigned int num)`
`47`	`47`	`{`
`48`	`48`	`// Store thread number in thread local variable`
`49`	`49`	`this_thread_num = num;`
Original file line number	Diff line number	Diff line change
`@@ -1264,7 +1264,7 @@ create_expire_tables(std::vector<expire_output_t> const &expire_outputs,`
`1264`	`1264`	`return;`
`1265`	`1265`	`}`
`1266`	`1266`
`1267`		`- pg_conn_t connection{conninfo};`
	`1267`	`+ pg_conn_t const connection{conninfo};`
`1268`	`1268`	`connection.exec("SET client_min_messages = WARNING");`
`1269`	`1269`	`for (auto &expire_output : expire_outputs) {`
`1270`	`1270`	`if (!expire_output.table().empty()) {`
Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ class make_ewkb_visitor`
`307`	`307`	`class ewkb_parser_t`
`308`	`308`	`{`
`309`	`309`	`public:`
`310`		`- ewkb_parser_t(std::string_view input)`
	`310`	`+ explicit ewkb_parser_t(std::string_view input)`
`311`	`311`	`: m_data(input),`
`312`	`312`	`m_max_length(static_cast<uint32_t>(input.size()) / (sizeof(double) * 2))`
`313`	`313`	`{}`