Revert "Fix signed/unsigned comparison"

joto · joto · commit 265cf9e4205a · 2022-01-27T11:49:43.000+01:00
Unfortunately using unsigned ints isn't a solution here, because we are creating negative numbers in this code which is UB then. This reverts commit 92b3ec5.
diff --git a/tests/test-output-flex-way-change.cpp b/tests/test-output-flex-way-change.cpp
@@ -44,8 +44,8 @@ TEST_CASE("change way from t1")
 
     options.append = true;
 
-    unsigned long num_t1 = 0;
-    unsigned long num_t2 = 0;
+    int num_t1 = 0;
+    int num_t2 = 0;
     std::string update;
     SECTION("to t2")
     {
@@ -87,8 +87,8 @@ TEST_CASE("change way from t2")
 
     options.append = true;
 
-    unsigned long num_t1 = 0;
-    unsigned long num_t2 = 0;
+    int num_t1 = 0;
+    int num_t2 = 0;
     std::string update;
     SECTION("to t1")
     {
@@ -131,8 +131,8 @@ TEST_CASE("change way from t1 and t2")
 
     options.append = true;
 
-    unsigned long num_t1 = 0;
-    unsigned long num_t2 = 0;
+    int num_t1 = 0;
+    int num_t2 = 0;
     std::string update;
     SECTION("to t1")
     {
diff --git a/tests/test-output-flex-way-del.cpp b/tests/test-output-flex-way-del.cpp
@@ -31,8 +31,8 @@ TEST_CASE("delete way: not a member")
 
     testing::db::data_t data{tdata};
 
-    unsigned long num_t1 = 0;
-    unsigned long num_tboth = 0;
+    int num_t1 = 0;
+    int num_tboth = 0;
     SECTION("in none") { data.add("w10 v1 dV Tt=ag Nn10,n11"); }
     SECTION("in t1")
     {
@@ -69,9 +69,9 @@ TEST_CASE("delete way: relation member")
 
     testing::db::data_t data{tdata};
 
-    unsigned long num_t1 = 0;
-    unsigned long num_t2 = 0;
-    unsigned long num_tboth = 0;
+    int num_t1 = 0;
+    int num_t2 = 0;
+    int num_tboth = 0;
 
     SECTION("in none")
     {
