Skip to content

Commit 20a4a1d

Browse files
committed
Add a (broken, disabled) test for non 100% node cache hit ratio
To test the node retrieval from database during initial import, add a test case for which not 100% of nodes fit into memory cache. The minimum cache size of 1MB is allready to big in optimized mode. In dense mode, things are sufficiently inefficient that even liechtenstein needs more than 1MB of node cache. However, --cache-strategy=dense appears broken at the moment. It gives the wrong geometries, likely due to wrongly retrieved nodes. This needs fixing before we can activate this test.
1 parent 19aa8ce commit 20a4a1d

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

tests/regression-test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,8 @@ def __init__(self):
186186
"testTwo")))
187187
self.addTest(BasicSlimTestCase("basic case", [], [0,1,2,3,13, 91, 92],[6,7,8,9]))
188188
self.addTest(BasicSlimTestCase("Parallel processing", ["--number-processes", "8", "-C100"], [0,1,2,3,13,91,92],[6,7,8,9]))
189+
#It looks like --cache-strategy=dense is broken, as it it produces wrong geometries.
190+
#self.addTest(BasicSlimTestCase("Parallel processing with non 100% node-cache", ["--number-processes", "8", "-C1", "--cache-strategy=dense"], [0,1,2,3,13,91,92],[6,7,8,9]))
189191
# Failes to do correct error checking. This needs fixing in osm2pgsql
190192
# self.addTest(BasicSlimTestCase("Parallel processing with failing database conneciton (connection limit exceeded)", ["--number-processes", "32", "-C100"], [0,1,2,3],[6,7,8,9]))
191193
# Counts are expected to be different in hstore, needs adjusted tests

0 commit comments

Comments
 (0)