Avoid warnings for use of constants in tile code

joto · joto · commit 171e0dcffacd · 2026-04-07T14:52:05.000+02:00
The quadkey code uses many magic constants only once or twice, there is
no sense in defining them separately.
diff --git a/src/tile.cpp b/src/tile.cpp
@@ -36,14 +36,17 @@ geom::point_t tile_t::to_world_coords(geom::point_t p,
 
 geom::point_t tile_t::center() const noexcept
 {
-    return to_world_coords({0.5, 0.5}, 1);
+    constexpr double MIDDLE = 0.5;
+    return to_world_coords({MIDDLE, MIDDLE}, 1);
 }
 
 namespace {
 
 // Quadkey implementation uses bit interleaving code from
 // https://github.com/lemire/Code-used-on-Daniel-Lemire-s-blog/blob/master/2018/01/08/interleave.c
 
+// NOLINTBEGIN(cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers)
+
 uint64_t interleave_uint32_with_zeros(uint32_t input) noexcept
 {
     uint64_t word = input;
@@ -66,6 +69,8 @@ uint32_t deinterleave_lowuint32(uint64_t word) noexcept
     return static_cast<uint32_t>(word);
 }
 
+// NOLINTEND(cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers)
+
 uint32_t parse_num_with_max(std::string const &str, uint32_t max)
 {
     std::size_t pos = 0;

Original file line number	Diff line number	Diff line change
`@@ -36,14 +36,17 @@ geom::point_t tile_t::to_world_coords(geom::point_t p,`
`36`	`36`
`37`	`37`	`geom::point_t tile_t::center() const noexcept`
`38`	`38`	`{`
`39`		`- return to_world_coords({0.5, 0.5}, 1);`
	`39`	`+ constexpr double MIDDLE = 0.5;`
	`40`	`+ return to_world_coords({MIDDLE, MIDDLE}, 1);`
`40`	`41`	`}`
`41`	`42`
`42`	`43`	`namespace {`
`43`	`44`
`44`	`45`	`// Quadkey implementation uses bit interleaving code from`
`45`	`46`	`// https://github.com/lemire/Code-used-on-Daniel-Lemire-s-blog/blob/master/2018/01/08/interleave.c`
`46`	`47`
	`48`	`+// NOLINTBEGIN(cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers)`
	`49`	`+`
`47`	`50`	`uint64_t interleave_uint32_with_zeros(uint32_t input) noexcept`
`48`	`51`	`{`
`49`	`52`	`uint64_t word = input;`
`@@ -66,6 +69,8 @@ uint32_t deinterleave_lowuint32(uint64_t word) noexcept`
`66`	`69`	`return static_cast<uint32_t>(word);`
`67`	`70`	`}`
`68`	`71`
	`72`	`+// NOLINTEND(cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers)`
	`73`	`+`
`69`	`74`	`uint32_t parse_num_with_max(std::string const &str, uint32_t max)`
`70`	`75`	`{`
`71`	`76`	`std::size_t pos = 0;`