In aspnet-webpack-react 3.0.0+, remove the workaround for aspnet#1066. Templates that use this version of the package need to not have issue aspnet#1066

SteveSandersonMS · SteveSandersonMS · commit 3da87dd3d335 · 2017-06-26T15:34:30.000+01:00
diff --git a/src/Microsoft.AspNetCore.SpaServices/npm/aspnet-webpack-react/package.json b/src/Microsoft.AspNetCore.SpaServices/npm/aspnet-webpack-react/package.json
@@ -1,12 +1,11 @@
 {
   "name": "aspnet-webpack-react",
-  "version": "2.0.1",
+  "version": "3.0.0-beta.1",
   "description": "Helpers for using Webpack with React in ASP.NET Core projects. Works in conjunction with the Microsoft.AspNetCore.SpaServices NuGet package.",
   "main": "index.js",
   "scripts": {
     "prepublish": "rimraf *.d.ts && tsc && echo 'Finished building NPM package \"aspnet-webpack-react\"'",
-    "test": "echo \"Error: no test specified\" && exit 1",
-    "postinstall": "node scripts/postinstall.js"
+    "test": "echo \"Error: no test specified\" && exit 1"
   },
   "author": "Microsoft",
   "license": "Apache-2.0",
@@ -17,12 +16,8 @@
     "type": "git",
     "url": "https://github.com/aspnet/JavaScriptServices.git"
   },
-  "dependencies": {
-    "@types/webpack": "2.2.15",
-    "hjson": "2.4.3"
-  },
   "devDependencies": {
-    "@types/react": "15.0.29",
+    "@types/webpack": "^2.2.0",
     "rimraf": "^2.5.4",
     "typescript": "^2.0.0",
     "webpack": "^2.2.0"
diff --git a/src/Microsoft.AspNetCore.SpaServices/npm/aspnet-webpack-react/scripts/postinstall.js b/src/Microsoft.AspNetCore.SpaServices/npm/aspnet-webpack-react/scripts/postinstall.js
diff --git a/src/Microsoft.AspNetCore.SpaServices/npm/aspnet-webpack-react/src/index.ts b/src/Microsoft.AspNetCore.SpaServices/npm/aspnet-webpack-react/src/index.ts
@@ -4,23 +4,3 @@ export { addReactHotModuleReplacementConfig } from './HotModuleReplacement';
 // compatibility with aspnet-webpack 1.x. In aspnet-webpack 2.0, we can drop the old name (and also deprecate
 // some other no-longer-supported functionality, such as LoadViaWebpack).
 export { addReactHotModuleReplacementConfig as addReactHotModuleReplacementBabelTransform } from './HotModuleReplacement';
-
-// Workaround for #1066
-//
-// The issue is that @types/react-router@4.0.12 is incompatible with @types/react@15.0.29
-// This is a problem because the ReactReduxSpa template that ships in 2.0.0-preview2 is pinned
-// to @types/react@15.0.29 but does *not* declare a direct dependency on @types/react-router,
-// which means we end up grabbing the latest @types/react-router.
-//
-// The temporary solution is for aspnet-webpack-react to add the following extra type information
-// that patches the compatibility issue. The longer-term solution will be for the templates to
-// pin versions of *every* package in the transitive closure, not just their direct dependencies.
-//
-// Note that for this workaround to work, the developer also needs 'aspnet-webpack-react' to be
-// present in the 'types' array in tsconfig.json. We automate the task of adding that in the
-// scripts/postinstall.js file in this package. Later, that action can be removed.
-
-import * as React from 'react';
-declare module 'react' {
-    interface Component<P, S={}> {}
-}
diff --git a/src/Microsoft.AspNetCore.SpaServices/npm/aspnet-webpack-react/tsconfig.json b/src/Microsoft.AspNetCore.SpaServices/npm/aspnet-webpack-react/tsconfig.json
@@ -5,7 +5,7 @@
     "target": "es5",
     "declaration": true,
     "outDir": ".",
-    "lib": ["dom", "es2015"]
+    "lib": ["es2015"]
   },
   "files": [
     "src/index.ts"
