test coverage for multiple interfaces

henryqdineen · andimarek · commit bda546e8d732 · 2018-03-23T10:39:47.000+11:00
diff --git a/src/main/java/graphql/language/AstPrinter.java b/src/main/java/graphql/language/AstPrinter.java
@@ -281,7 +281,7 @@ private static NodePrinter<ObjectTypeDefinition> objectTypeDefinition() {
             out.printf("%s", spaced(
                     "type",
                     node.getName(),
-                    wrap("implements ", join(node.getImplements(), ", "), ""),
+                    wrap("implements ", join(node.getImplements(), " & "), ""),
                     directives(node.getDirectives()),
                     block(node.getFieldDefinitions())
             ));
diff --git a/src/test/groovy/graphql/language/AstPrinterTest.groovy b/src/test/groovy/graphql/language/AstPrinterTest.groovy
@@ -51,15 +51,19 @@ interface Character {
     appearsIn: [Episode]!
 }
 
-type Human implements Character {
+interface Node {
+  id: ID!
+}
+
+type Human implements Character & Node {
     id: ID!
     name: String!
     friends: [Character]
     appearsIn: [Episode]!
     homePlanet: String
 }
 
-type Droid implements Character {
+type Droid implements Character & Node {
     id: ID!
     name: String!
     friends: [Character]
@@ -69,7 +73,7 @@ type Droid implements Character {
 
 union SearchResult = Human | Droid | Starship
 
-type Review {
+type Review implements Node {
   id: ID!
   stars: Int!
   commentary: String
@@ -122,15 +126,19 @@ interface Character {
   appearsIn: [Episode]!
 }
 
-type Human implements Character {
+interface Node {
+  id: ID!
+}
+
+type Human implements Character & Node {
   id: ID!
   name: String!
   friends: [Character]
   appearsIn: [Episode]!
   homePlanet: String
 }
 
-type Droid implements Character {
+type Droid implements Character & Node {
   id: ID!
   name: String!
   friends: [Character]
@@ -140,7 +148,7 @@ type Droid implements Character {
 
 union SearchResult = Human | Droid | Starship
 
-type Review {
+type Review implements Node {
   id: ID!
   stars: Int!
   commentary: String
diff --git a/src/test/groovy/graphql/schema/idl/SchemaPrinterTest.groovy b/src/test/groovy/graphql/schema/idl/SchemaPrinterTest.groovy
@@ -40,6 +40,7 @@ class SchemaPrinterTest extends Specification {
     GraphQLSchema starWarsSchema() {
         def wiring = newRuntimeWiring()
                 .type("Character", { type -> type.typeResolver(resolver) } as UnaryOperator<TypeRuntimeWiring.Builder>)
+                .type("Node", { type -> type.typeResolver(resolver) } as UnaryOperator<TypeRuntimeWiring.Builder>)
                 .scalar(ASTEROID)
                 .build()
         GraphQLSchema schema = load("starWarsSchemaExtended.graphqls", wiring)
@@ -644,7 +645,11 @@ type TypeE {
   name: String!
 }
 
-type Droid implements Character {
+interface Node {
+  id: ID!
+}
+
+type Droid implements Character & Node {
   appearsIn: [Episode]!
   friends: [Character]
   id: ID!
@@ -653,7 +658,7 @@ type Droid implements Character {
   primaryFunction: String
 }
 
-type Human implements Character {
+type Human implements Character & Node {
   appearsIn: [Episode]!
   friends: [Character]
   homePlanet: String
@@ -669,6 +674,12 @@ type Planet {
 type Query {
   droid(id: ID!): Droid
   hero(episode: Episode): Character
+  node(id: ID!): Node
+}
+
+type Starship implements Node {
+  id: ID!
+  name: String
 }
 
 enum Episode {
diff --git a/src/test/resources/starWarsSchemaExtended.graphqls b/src/test/resources/starWarsSchemaExtended.graphqls
@@ -5,6 +5,7 @@ schema {
 type Query {
     hero(episode: Episode): Character
     droid(id: ID!): Droid
+    node(id: ID!): Node
 }
 
 enum Episode {
@@ -20,15 +21,19 @@ interface Character {
     appearsIn: [Episode]!
 }
 
-type Human implements Character {
+interface Node {
+  id: ID!
+}
+
+type Human implements Character & Node {
     id: ID!
     name: String!
     friends: [Character]
     appearsIn: [Episode]!
     homePlanet: String
 }
 
-type Droid implements Character {
+type Droid implements Character & Node {
     id: ID!
     name: String!
     friends: [Character]
@@ -42,4 +47,9 @@ type Planet {
     hitBy : Asteroid
 }
 
+type Starship implements Node {
+    id: ID!
+    name : String
+}
+
 scalar Asteroid
