Remove unsafe_object_new

msimacek · msimacek · commit abd79fb9bff5 · 2025-12-22T19:17:12.000+01:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/GraalPythonModuleBuiltins.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/GraalPythonModuleBuiltins.java
@@ -123,7 +123,6 @@
 import com.oracle.graal.python.builtins.objects.method.PBuiltinMethod;
 import com.oracle.graal.python.builtins.objects.method.PMethod;
 import com.oracle.graal.python.builtins.objects.module.PythonModule;
-import com.oracle.graal.python.builtins.objects.object.ObjectBuiltins;
 import com.oracle.graal.python.builtins.objects.object.PythonObject;
 import com.oracle.graal.python.builtins.objects.set.PSet;
 import com.oracle.graal.python.builtins.objects.str.StringUtils;
@@ -1395,19 +1394,4 @@ static PTuple doCreate(long arrowArrayAddr, long arrowSchemaAddr,
             return PFactory.createTuple(ctx.getLanguage(inliningTarget), new Object[]{arrowSchemaCapsule, arrowArrayCapsule});
         }
     }
-
-    /**
-     * Used from datetime module to create new instances of objects that we allow subclassing from
-     * native. It's necessary, because the __new__ wrapper would reject native subclasses that
-     * override tp_new.
-     */
-    @Builtin(name = "unsafe_object_new", minNumOfPositionalArgs = 1)
-    @GenerateNodeFactory
-    abstract static class UnsafeObjectNewNode extends PythonUnaryBuiltinNode {
-        @Specialization
-        static Object create(VirtualFrame frame, Object cls,
-                        @Cached ObjectBuiltins.ObjectNode objectNode) {
-            return objectNode.execute(frame, cls, PythonUtils.EMPTY_OBJECT_ARRAY, PKeyword.EMPTY_KEYWORDS);
-        }
-    }
 }
diff --git a/graalpython/lib-python/3/_pydatetime.py b/graalpython/lib-python/3/_pydatetime.py
@@ -696,8 +696,7 @@ def __new__(cls, days=0, seconds=0, microseconds=0,
         if abs(d) > 999999999:
             raise OverflowError("timedelta # of days is too large: %d" % d)
 
-        # GraalPy change: unsafe ctor to allow native subclasses
-        self = __graalpython__.unsafe_object_new(cls)
+        self = object.__new__(cls)
         self._days = d
         self._seconds = s
         self._microseconds = us
@@ -954,14 +953,12 @@ def __new__(cls, year, month=None, day=None):
                         "Failed to encode latin1 string when unpickling "
                         "a date object. "
                         "pickle.load(data, encoding='latin1') is assumed.")
-            # GraalPy change: unsafe ctor to allow native subclasses
-            self = __graalpython__.unsafe_object_new(cls)
+            self = object.__new__(cls)
             self.__setstate(year)
             self._hashcode = -1
             return self
         year, month, day = _check_date_fields(year, month, day)
-        # GraalPy change: unsafe ctor to allow native subclasses
-        self = __graalpython__.unsafe_object_new(cls)
+        self = object.__new__(cls)
         self._year = year
         self._month = month
         self._day = day
@@ -1373,16 +1370,14 @@ def __new__(cls, hour=0, minute=0, second=0, microsecond=0, tzinfo=None, *, fold
                         "Failed to encode latin1 string when unpickling "
                         "a time object. "
                         "pickle.load(data, encoding='latin1') is assumed.")
-            # GraalPy change: unsafe ctor to allow native subclasses
-            self = __graalpython__.unsafe_object_new(cls)
+            self = object.__new__(cls)
             self.__setstate(hour, minute or None)
             self._hashcode = -1
             return self
         hour, minute, second, microsecond, fold = _check_time_fields(
             hour, minute, second, microsecond, fold)
         _check_tzinfo_arg(tzinfo)
-        # GraalPy change: unsafe ctor to allow native subclasses
-        self = __graalpython__.unsafe_object_new(cls)
+        self = object.__new__(cls)
         self._hour = hour
         self._minute = minute
         self._second = second
@@ -1703,17 +1698,15 @@ def __new__(cls, year, month=None, day=None, hour=0, minute=0, second=0,
                         "Failed to encode latin1 string when unpickling "
                         "a datetime object. "
                         "pickle.load(data, encoding='latin1') is assumed.")
-            # GraalPy change: unsafe ctor to allow native subclasses
-            self = __graalpython__.unsafe_object_new(cls)
+            self = object.__new__(cls)
             self.__setstate(year, month)
             self._hashcode = -1
             return self
         year, month, day = _check_date_fields(year, month, day)
         hour, minute, second, microsecond, fold = _check_time_fields(
             hour, minute, second, microsecond, fold)
         _check_tzinfo_arg(tzinfo)
-        # GraalPy change: unsafe ctor to allow native subclasses
-        self = __graalpython__.unsafe_object_new(cls)
+        self = object.__new__(cls)
         self._year = year
         self._month = month
         self._day = day
