Implement ForeignTime methods

timfel · timfel · commit 81ddbfe6e6ef · 2026-03-27T09:28:34.000+01:00
diff --git a/graalpython/com.oracle.graal.python.test/src/tests/test_interop.py b/graalpython/com.oracle.graal.python.test/src/tests/test_interop.py
@@ -242,6 +242,31 @@ def test_foreign_date_behavior(self):
         self.assertEqual(d - datetime.date(2025, 3, 20), datetime.timedelta(days=3))
         self.assertEqual(d - LocalDate.of(2025, 3, 20), datetime.timedelta(days=3))
 
+    def test_foreign_time_behavior(self):
+        import datetime
+        import java
+
+        LocalTime = java.type("java.time.LocalTime")
+
+        t = LocalTime.of(7, 8, 9)
+        self.assertEqual(t.hour, 7)
+        self.assertEqual(t.minute, 8)
+        self.assertEqual(t.second, 9)
+        self.assertEqual(t.microsecond, 0)
+        self.assertEqual(str(t), "07:08:09")
+        self.assertEqual(t.isoformat(), "07:08:09")
+        self.assertEqual(t.strftime("%H:%M:%S"), "07:08:09")
+        self.assertEqual(format(t, "%H:%M:%S"), "07:08:09")
+        self.assertEqual(hash(t), hash(datetime.time(7, 8, 9)))
+        self.assertEqual(t, datetime.time(7, 8, 9))
+        self.assertEqual(t, LocalTime.of(7, 8, 9))
+        self.assertEqual(t.replace(second=10), datetime.time(7, 8, 10))
+        self.assertLess(t, datetime.time(7, 8, 10))
+        self.assertIsNone(t.tzinfo)
+        self.assertIsNone(t.utcoffset())
+        self.assertIsNone(t.dst())
+        self.assertIsNone(t.tzname())
+
     def test_read(self):
         o = CustomObject()
         assert polyglot.__read__(o, "field") == o.field
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/Python3Core.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/Python3Core.java
@@ -269,6 +269,7 @@
 import com.oracle.graal.python.builtins.objects.foreign.ForeignIterableBuiltins;
 import com.oracle.graal.python.builtins.objects.foreign.ForeignNumberBuiltins;
 import com.oracle.graal.python.builtins.objects.foreign.ForeignObjectBuiltins;
+import com.oracle.graal.python.builtins.objects.foreign.ForeignTimeBuiltins;
 import com.oracle.graal.python.builtins.objects.frame.FrameBuiltins;
 import com.oracle.graal.python.builtins.objects.function.AbstractFunctionBuiltins;
 import com.oracle.graal.python.builtins.objects.function.BuiltinFunctionBuiltins;
@@ -502,6 +503,7 @@ private static PythonBuiltins[] initializeBuiltins(TruffleLanguage.Env env) {
                         new ForeignNumberBuiltins(),
                         new ForeignBooleanBuiltins(),
                         new ForeignDateBuiltins(),
+                        new ForeignTimeBuiltins(),
                         new ForeignAbstractClassBuiltins(),
                         new ForeignExecutableBuiltins(),
                         new ForeignInstantiableBuiltins(),
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/PythonBuiltinClassType.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/PythonBuiltinClassType.java
@@ -187,6 +187,7 @@
 import com.oracle.graal.python.builtins.objects.foreign.ForeignIterableBuiltins;
 import com.oracle.graal.python.builtins.objects.foreign.ForeignNumberBuiltins;
 import com.oracle.graal.python.builtins.objects.foreign.ForeignObjectBuiltins;
+import com.oracle.graal.python.builtins.objects.foreign.ForeignTimeBuiltins;
 import com.oracle.graal.python.builtins.objects.frame.FrameBuiltins;
 import com.oracle.graal.python.builtins.objects.function.AbstractFunctionBuiltins;
 import com.oracle.graal.python.builtins.objects.function.FunctionBuiltins;
@@ -844,7 +845,7 @@ It can be called either on the class (e.g. C.f()) or on an instance
     ForeignInstantiable("ForeignInstantiable", ForeignObject, newBuilder().publishInModule(J_POLYGLOT).basetype().addDict().slots(ForeignInstantiableBuiltins.SLOTS)),
     ForeignIterable("ForeignIterable", ForeignObject, newBuilder().publishInModule(J_POLYGLOT).basetype().addDict().disallowInstantiation().slots(ForeignIterableBuiltins.SLOTS)),
     ForeignDate("ForeignDate", PDate, newBuilder().publishInModule(J_POLYGLOT).basetype().addDict().disallowInstantiation().slots(ForeignDateBuiltins.SLOTS)),
-    ForeignTime("ForeignTime", PTime, newBuilder().publishInModule(J_POLYGLOT).basetype().addDict().disallowInstantiation()),
+    ForeignTime("ForeignTime", PTime, newBuilder().publishInModule(J_POLYGLOT).basetype().addDict().disallowInstantiation().slots(ForeignTimeBuiltins.SLOTS)),
     ForeignDateTime("ForeignDateTime", PDateTime, newBuilder().publishInModule(J_POLYGLOT).basetype().addDict().disallowInstantiation()),
     ForeignTimeZone("ForeignTimeZone", PTzInfo, newBuilder().publishInModule(J_POLYGLOT).basetype().addDict().disallowInstantiation()),
 
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/foreign/ForeignTimeBuiltins.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/foreign/ForeignTimeBuiltins.java
