check for redefine in attr being copied _from_, not to - ?!

mpictor · mpictor · commit 42e88253bc00 · 2013-10-09T21:31:57.000-04:00
I do not understand how this could have been right or how it did not
cause problems if wrong. Perhaps redefined attr's are used so
infrequently that it went unnoticed?
diff --git a/src/clstepcore/STEPattribute.cc b/src/clstepcore/STEPattribute.cc
@@ -642,8 +642,9 @@ void STEPattribute::STEPwrite( ostream & out, const char * currSch ) {
 
 
 int STEPattribute::ShallowCopy( STEPattribute * sa ) {
-    if( RedefiningAttr() )  {
-        return RedefiningAttr()->ShallowCopy( sa );
+    _redefAttr = sa->_redefAttr;
+    if( _redefAttr )  {
+        return _redefAttr->ShallowCopy( sa );
     }
     switch( sa->NonRefType() ) {
         case INTEGER_TYPE:
