Skip to content

Commit 8806251

Browse files
committed
added warning commentz
1 parent 469051b commit 8806251

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

v4-cokapi/backends/javascript/jslogger.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -835,7 +835,7 @@ function listener(event, execState, eventData, data) {
835835

836836
finalize();
837837
// GET OUTTA HERE so that the user's script doesn't keep infinite looping
838-
process.exit();
838+
process.exit(); // NB: on Node v6 this will CUT OFF the stdout output to terminal (but OK if redirected to file), ergh :(
839839
} else {
840840
assert(stepType !== undefined);
841841
execState.prepareStep(stepType); // set debugger to stop at next step
@@ -922,7 +922,7 @@ if (argv.typescript) {
922922
errorTraceEntry.line = firstErr.line;
923923
curTrace.push(errorTraceEntry);
924924
finalize();
925-
process.exit(); // bail out early!!!
925+
process.exit(); // bail out early!!! // NB: on Node v6 this will CUT OFF the stdout output to terminal (but OK if redirected to file), ergh :(
926926
} else {
927927
// strip off the final line, which should say something like:
928928
// '//# sourceMappingURL=file.js.map'
@@ -949,6 +949,7 @@ try {
949949
catch (e) {
950950
// for some reason, the node debugger doesn't allow us to keep going
951951
// after an uncaught exception to, say, execute 'finally' clauses.
952+
// NB: is this still true for Node v6.0? Maybe not.
952953
if (curTrace.length > 0) {
953954
// do a NOP for now ... it's weird to issue an uncaught_exception since
954955
// that's usually reserved for syntax errors

0 commit comments

Comments
 (0)