extends route attr to route group and collection

jknack · jknack · commit d97ddec4f66e · 2016-04-04T11:12:39.000-03:00
diff --git a/jooby/src/main/java/org/jooby/Route.java b/jooby/src/main/java/org/jooby/Route.java
@@ -556,6 +556,33 @@ public Group produces(final String... types) {
       return this;
     }
 
+    /**
+     * Set route attribute.
+     *
+     * @param name Attribute's name.
+     * @param value Attribute's value.
+     * @return This instance.
+     */
+    public Group attr(final String name, final String value) {
+      for (Definition definition : routes) {
+        definition.attr(name, value);
+      }
+      return this;
+    }
+
+    /**
+     * Tell jooby what renderer should use to render the output.
+     *
+     * @param name A renderer's name.
+     * @return This instance.
+     */
+    public Group renderer(final String name) {
+      for (Definition definition : routes) {
+        definition.renderer(name);
+      }
+      return this;
+    }
+
     private void newRoute(final String method, final String pattern,
         final Route.Filter filter) {
       newRoute(new Route.Definition(method, this.rootPattern + pattern, filter));
@@ -594,15 +621,15 @@ private void newRoute(final Route.Definition route) {
   class Collection {
 
     /** List of definitions. */
-    private Route.Definition[] definitions;
+    private Route.Definition[] routes;
 
     /**
      * Creates a new collection of route definitions.
      *
      * @param definitions Collection of route definitions.
      */
-    public Collection(final Route.Definition[] definitions) {
-      this.definitions = requireNonNull(definitions, "Route definitions are required.");
+    public Collection(final Route.Definition... definitions) {
+      this.routes = requireNonNull(definitions, "Route definitions are required.");
     }
 
     /**
@@ -612,7 +639,7 @@ public Collection(final Route.Definition[] definitions) {
      * @return This instance.
      */
     public Collection name(final String name) {
-      for (Definition definition : definitions) {
+      for (Definition definition : routes) {
         definition.name(name);
       }
       return this;
@@ -625,7 +652,7 @@ public Collection name(final String name) {
      * @return This instance.
      */
     public Collection consumes(final MediaType... types) {
-      for (Definition definition : definitions) {
+      for (Definition definition : routes) {
         definition.consumes(types);
       }
       return this;
@@ -638,7 +665,7 @@ public Collection consumes(final MediaType... types) {
      * @return This instance.
      */
     public Collection consumes(final String... types) {
-      for (Definition definition : definitions) {
+      for (Definition definition : routes) {
         definition.consumes(types);
       }
       return this;
@@ -651,7 +678,7 @@ public Collection consumes(final String... types) {
      * @return This instance.
      */
     public Collection produces(final MediaType... types) {
-      for (Definition definition : definitions) {
+      for (Definition definition : routes) {
         definition.produces(types);
       }
       return this;
@@ -664,11 +691,39 @@ public Collection produces(final MediaType... types) {
      * @return This instance.
      */
     public Collection produces(final String... types) {
-      for (Definition definition : definitions) {
+      for (Definition definition : routes) {
         definition.produces(types);
       }
       return this;
     }
+
+    /**
+     * Set route attribute.
+     *
+     * @param name Attribute's name.
+     * @param value Attribute's value.
+     * @return This instance.
+     */
+    public Collection attr(final String name, final String value) {
+      for (Definition definition : routes) {
+        definition.attr(name, value);
+      }
+      return this;
+    }
+
+    /**
+     * Tell jooby what renderer should use to render the output.
+     *
+     * @param name A renderer's name.
+     * @return This instance.
+     */
+    public Collection renderer(final String name) {
+      for (Definition definition : routes) {
+        definition.renderer(name);
+      }
+      return this;
+    }
+
   }
 
   /**
diff --git a/jooby/src/test/java/org/jooby/RouteCollectionTest.java b/jooby/src/test/java/org/jooby/RouteCollectionTest.java
@@ -0,0 +1,29 @@
+package org.jooby;
+
+import static org.junit.Assert.assertEquals;
+
+import org.jooby.Route.Definition;
+import org.junit.Test;
+
+public class RouteCollectionTest {
+
+  @Test
+  public void renderer() {
+    Definition def = new Route.Definition("*", "*", (req, rsp, chain) -> {
+    });
+    new Route.Collection(def)
+        .renderer("json");
+
+    assertEquals("json", def.attr("renderer").get());
+  }
+
+  @Test
+  public void attr() {
+    Definition def = new Route.Definition("*", "*", (req, rsp, chain) -> {
+    });
+    new Route.Collection(def)
+        .attr("foo", "bar");
+
+    assertEquals("bar", def.attr("foo").get());
+  }
+}
diff --git a/jooby/src/test/java/org/jooby/RouteGroupTest.java b/jooby/src/test/java/org/jooby/RouteGroupTest.java
@@ -247,17 +247,37 @@ public void producesType() {
     assertEquals(MediaType.json, ns.routes().iterator().next().produces().iterator().next());
   }
 
+  @Test
+  public void renderer() {
+    Group ns = new Route.Group("/ns");
+    ns.patch("/p", (req, rsp, chain) -> {
+    }).renderer("json");
+
+    assertEquals("json", ns.routes().iterator().next().attr("renderer").get());
+  }
+
+  @Test
+  public void attr() {
+    Group ns = new Route.Group("/ns");
+    ns.patch("/p", (req, rsp, chain) -> {
+    }).attr("foo", "bar");
+
+    assertEquals("bar", ns.routes().iterator().next().attr("foo").get());
+  }
+
   private void matches(final List<Route.Definition> routes, final String method,
       final String pattern) {
     for (Route.Definition r : routes) {
-      assertTrue(r.matches(method.toUpperCase(), pattern, MediaType.all, MediaType.ALL).isPresent());
+      assertTrue(
+          r.matches(method.toUpperCase(), pattern, MediaType.all, MediaType.ALL).isPresent());
     }
   }
 
   private void noMatches(final List<Route.Definition> routes, final String method,
       final String pattern) {
     for (Route.Definition r : routes) {
-      assertFalse(r.matches(method.toUpperCase(), pattern, MediaType.all, MediaType.ALL).isPresent());
+      assertFalse(
+          r.matches(method.toUpperCase(), pattern, MediaType.all, MediaType.ALL).isPresent());
     }
   }
 
