Skip to content

Commit 6579ff2

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Avoid silent skip for zookeeper config problems"
2 parents f4ef2cc + 9d11fa7 commit 6579ff2

1 file changed

Lines changed: 5 additions & 10 deletions

File tree

taskflow/tests/unit/persistence/test_zk_persistence.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,11 @@ def setUp(self):
5858
# Create a unique path just for this test (so that we don't overwrite
5959
# what other tests are doing).
6060
conf['path'] = TEST_PATH_TPL % (uuidutils.generate_uuid())
61-
try:
62-
self.backend = impl_zookeeper.ZkBackend(conf)
63-
except Exception as e:
64-
self.skipTest("Failed creating backend created from configuration"
65-
" %s due to %s" % (conf, e))
66-
else:
67-
self.addCleanup(self.backend.close)
68-
self.addCleanup(clean_backend, self.backend, conf)
69-
with contextlib.closing(self.backend.get_connection()) as conn:
70-
conn.upgrade()
61+
self.backend = impl_zookeeper.ZkBackend(conf)
62+
self.addCleanup(self.backend.close)
63+
self.addCleanup(clean_backend, self.backend, conf)
64+
with contextlib.closing(self.backend.get_connection()) as conn:
65+
conn.upgrade()
7166

7267
def test_zk_persistence_entry_point(self):
7368
conf = {'connection': 'zookeeper:'}

0 commit comments

Comments
 (0)