Cleanup after install

ajaeger · ajaeger · commit 9962403d3c52 · 2016-08-28T08:48:23.000+02:00
Tox tests are run on developer machines and on long lived slaves. We
should not leave lots of directories like
/tmp/python-openstackclient-tox_install-sdnltRu lying around.

Instead delete the temporary directory after our run.

Remove also an obsolete comment.

Change-Id: I939eae82dba3287fd4e4086128ebf4609a0e0770
diff --git a/tools/tox_install.sh b/tools/tox_install.sh
@@ -16,6 +16,7 @@ shift
 
 install_cmd="pip install"
 mydir=$(mktemp -dt "$CLIENT_NAME-tox_install-XXXXXXX")
+trap "rm -rf $mydir" EXIT
 localfile=$mydir/upper-constraints.txt
 if [[ $CONSTRAINTS_FILE != http* ]]; then
     CONSTRAINTS_FILE=file://$CONSTRAINTS_FILE
@@ -27,7 +28,6 @@ if [ $requirements_installed -eq 0 ]; then
     echo "ALREADY INSTALLED" > /tmp/tox_install.txt
     echo "Requirements already installed; using existing package"
 elif [ -x "$ZUUL_CLONER" ]; then
-    # If this is called in a periodic job, these will not be set
     echo "ZUUL CLONER" > /tmp/tox_install.txt
     pushd $mydir
     $ZUUL_CLONER --cache-dir \
