Skip to content

Commit 967d929

Browse files
committed
Migrate to flake8.
Fixes bug 1172444 Change-Id: Ieca721663aea2fd31753df4abfb5b01a7145b26a
1 parent 016a0b3 commit 967d929

3 files changed

Lines changed: 14 additions & 5 deletions

File tree

openstackclient/shell.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from cliff import help
2525

2626
from openstackclient.common import clientmanager
27-
from openstackclient.common.commandmanager import CommandManager
27+
from openstackclient.common import commandmanager
2828
from openstackclient.common import exceptions as exc
2929
from openstackclient.common import openstackkeyring
3030
from openstackclient.common import utils
@@ -63,7 +63,7 @@ def __init__(self):
6363
super(OpenStackShell, self).__init__(
6464
description=__doc__.strip(),
6565
version=VERSION,
66-
command_manager=CommandManager('openstack.cli'))
66+
command_manager=commandmanager.CommandManager('openstack.cli'))
6767

6868
# This is instantiated in initialize_app() only when using
6969
# password flow auth

tools/test-requires

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,16 @@
1+
# Install bounded pep8/pyflakes first, then let flake8 install
2+
pep8==1.4.5
3+
pyflakes==0.7.2
4+
flake8==2.0
5+
hacking>=0.5.3,<0.6
6+
17
distribute>=0.6.24
28

39
coverage
410
discover
511
fixtures>=0.3.12
612
mock
713
openstack.nose_plugin
8-
pep8==1.3.3
914
sphinx>=1.1.2
1015
testrepository>=0.0.13
1116
testtools>=0.9.26

tox.ini

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ deps = -r{toxinidir}/tools/pip-requires
1111
commands = python setup.py testr --testr-args='{posargs}'
1212

1313
[testenv:pep8]
14-
deps = pep8==1.3.3
15-
commands = pep8 --ignore=E126,E202,W602 --repeat --show-source openstackclient setup.py
14+
commands = flake8
1615

1716
[testenv:venv]
1817
commands = {posargs}
@@ -22,3 +21,8 @@ commands = python setup.py testr --coverage --testr-args='{posargs}'
2221

2322
[tox:jenkins]
2423
downloadcache = ~/cache/pip
24+
25+
[flake8]
26+
ignore = E126,E202,W602,H402
27+
show-source = True
28+
exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools

0 commit comments

Comments
 (0)