Remove now-unnecessary client creation hacks

Dean Troyer · Dean Troyer · commit 0de67016c7da · 2014-10-18T00:01:45.000-05:00
Clients that can use ksc Session don't need the old junk to
fake auth anymore:
* compute
* volume

Clients that still need to be fed credentials can pick directly
from the auth object in clientmanager.  The _token attribute is
removed, the token can be retrieved from the auth object:

  openstackclient/tests/common/test_clientmanager.py

This change will break any plugin that relies on getting a token
from instance._token. They should be updated to use the above, or
preferable, to use keystoneclient.session.Session to create its
HTTP interface object.

Change-Id: I877a29de97a42f85f12a14c274fc003e6fba5135
diff --git a/openstackclient/common/clientmanager.py b/openstackclient/common/clientmanager.py
@@ -106,9 +106,6 @@ def __init__(self, auth_options, api_version=None, verify=True):
             self.auth_ref = self.auth.get_auth_ref(self.session)
             self._service_catalog = self.auth_ref.service_catalog
 
-        # This begone when clients no longer need it...
-        self._token = self.auth.get_token(self.session)
-
         return
 
     def get_endpoint_for_service_type(self, service_type, region_name=None):
diff --git a/openstackclient/compute/client.py b/openstackclient/compute/client.py
@@ -43,21 +43,14 @@ def make_client(instance):
     http_log_debug = utils.get_effective_log_level() <= logging.DEBUG
 
     extensions = [extension.Extension('list_extensions', list_extensions)]
+
     client = compute_client(
         session=instance.session,
         extensions=extensions,
         http_log_debug=http_log_debug,
         timings=instance.timing,
     )
 
-    # Populate the Nova client to skip another auth query to Identity
-    if 'token' not in instance._auth_params:
-        # password flow
-        client.client.management_url = instance.get_endpoint_for_service_type(
-            API_NAME, region_name=instance._region_name)
-        client.client.service_catalog = instance._service_catalog
-    client.client.auth_token = instance.auth.get_token(instance.session)
-
     return client
 
 
diff --git a/openstackclient/image/client.py b/openstackclient/image/client.py
@@ -45,7 +45,7 @@ def make_client(instance):
 
     return image_client(
         instance._url,
-        token=instance._token,
+        token=instance.auth.get_token(instance.session),
         cacert=instance._cacert,
         insecure=instance._insecure,
     )
diff --git a/openstackclient/network/client.py b/openstackclient/network/client.py
@@ -44,7 +44,7 @@ def make_client(instance):
         region_name=instance._region_name,
         auth_url=instance._auth_url,
         endpoint_url=instance._url,
-        token=instance._token,
+        token=instance.auth.get_token(instance.session),
         insecure=instance._insecure,
         ca_cert=instance._cacert,
     )
diff --git a/openstackclient/tests/common/test_clientmanager.py b/openstackclient/tests/common/test_clientmanager.py
@@ -89,10 +89,9 @@ def test_client_manager_token_endpoint(self):
             fakes.AUTH_URL,
             client_manager._url,
         )
-
         self.assertEqual(
             fakes.AUTH_TOKEN,
-            client_manager._token,
+            client_manager.auth.get_token(None),
         )
         self.assertIsInstance(
             client_manager.auth,
@@ -111,10 +110,6 @@ def test_client_manager_token(self):
             verify=True
         )
 
-        self.assertEqual(
-            fakes.AUTH_TOKEN,
-            client_manager._token,
-        )
         self.assertEqual(
             fakes.AUTH_URL,
             client_manager._auth_url,
@@ -160,10 +155,6 @@ def test_client_manager_password(self):
             AUTH_REF,
             client_manager.auth_ref,
         )
-        self.assertEqual(
-            fakes.AUTH_TOKEN,
-            client_manager._token,
-        )
         self.assertEqual(
             dir(SERVICE_CATALOG),
             dir(client_manager._service_catalog),
diff --git a/openstackclient/volume/client.py b/openstackclient/volume/client.py
@@ -49,29 +49,13 @@ def make_client(instance):
     http_log_debug = utils.get_effective_log_level() <= logging.DEBUG
 
     extensions = [extension.Extension('list_extensions', list_extensions)]
+
     client = volume_client(
-        username=instance._username,
-        api_key=instance._password,
-        project_id=instance._project_name,
-        auth_url=instance._auth_url,
-        cacert=instance._cacert,
-        insecure=instance._insecure,
-        region_name=instance._region_name,
+        session=instance.session,
         extensions=extensions,
         http_log_debug=http_log_debug,
     )
 
-    # Populate the Cinder client to skip another auth query to Identity
-    if instance._url:
-        # token flow
-        client.client.management_url = instance._url
-    else:
-        # password flow
-        client.client.management_url = instance.get_endpoint_for_service_type(
-            API_NAME, region_name=instance._region_name)
-        client.client.service_catalog = instance._service_catalog
-    client.client.auth_token = instance._token
-
     return client
 
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ def make_client(instance):`
`45`	`45`
`46`	`46`	`return image_client(`
`47`	`47`	`instance._url,`
`48`		`- token=instance._token,`
	`48`	`+ token=instance.auth.get_token(instance.session),`
`49`	`49`	`cacert=instance._cacert,`
`50`	`50`	`insecure=instance._insecure,`
`51`	`51`	`)`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ def make_client(instance):`
`44`	`44`	`region_name=instance._region_name,`
`45`	`45`	`auth_url=instance._auth_url,`
`46`	`46`	`endpoint_url=instance._url,`
`47`		`- token=instance._token,`
	`47`	`+ token=instance.auth.get_token(instance.session),`
`48`	`48`	`insecure=instance._insecure,`
`49`	`49`	`ca_cert=instance._cacert,`
`50`	`50`	`)`