FUP: Add volume-update CLI pre V285 tests

1049965823 · 1049965823 · commit c5f29d683315 · 2020-04-10T08:39:39.000+08:00
This commit mainly to fix some comments from [1]. [1]https://review.opendev.org/#/c/712651/19/novaclient/tests/unit/v2/test_shell.py@4001 Blueprint: destroy-instance-with-datavolume Change-Id: Id809f22d0da2cdedf33a2c0df202f3953fd01673
diff --git a/doc/source/cli/nova.rst b/doc/source/cli/nova.rst
@@ -3966,11 +3966,13 @@ new volume.
 
 ``--delete-on-termination``
   Specify that the volume should be deleted when the server is destroyed.
+  It is mutually exclusive with '--no-delete-on-termination'.
   (Supported by API versions '2.85' - '2.latest')
 
 ``--no-delete-on-termination``
   Specify that the attached volume should not be deleted when
-  the server is destroyed. (Supported by API versions '2.85' - '2.latest')
+  the server is destroyed. It is mutually exclusive with '--delete-on-termination'.
+  (Supported by API versions '2.85' - '2.latest')
 
 .. _nova_bash-completion:
 
diff --git a/novaclient/tests/unit/v2/test_shell.py b/novaclient/tests/unit/v2/test_shell.py
@@ -4006,6 +4006,18 @@ def test_volume_update_swap_v285(self):
         self.assert_called('PUT', '/servers/1234/os-volume_attachments/Work',
                            {'volumeAttachment': {'volumeId': 'Work'}})
 
+    def test_volume_update_delete_on_termination_pre_v285(self):
+        self.assertRaises(
+            SystemExit, self.run_command,
+            'volume-update sample-server --delete-on-termination Work Work',
+            api_version='2.84')
+
+    def test_volume_update_no_delete_on_termination_pre_v285(self):
+        self.assertRaises(
+            SystemExit, self.run_command,
+            'volume-update sample-server --no-delete-on-termination Work Work',
+            api_version='2.84')
+
     def test_volume_update_v285(self):
         self.run_command('volume-update sample-server --delete-on-termination '
                          'Work Work', api_version='2.85')
