Skip to content

Commit 5989ae0

Browse files
CyrilRoelandteNovanceCyrilRoelandteNovance
committed
Remove useless glanceclient/common/https.py
No code from this file is used anywhere else in the client. This file should probably have been removed after merging the following commits: - 28c003d - 618637a Also remove all references to VerifiedHTTPSConnection from test_ssl.py. Conveniently, this also gets rid of all eventlet imports. Change-Id: I9d8b1020a296de60c196a82ad6e109b51f0a0761 Signed-off-by: Cyril Roelandt <cyril@redhat.com>
1 parent 08f9379 commit 5989ae0

2 files changed

Lines changed: 4 additions & 254 deletions

File tree

‎glanceclient/common/https.py‎

Lines changed: 0 additions & 250 deletions
This file was deleted.

‎glanceclient/tests/unit/test_ssl.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def test_v2_requests_valid_cert_verification(self, __):
158158

159159
@mock.patch('sys.stderr')
160160
def test_v2_requests_valid_cert_verification_no_compression(self, __):
161-
"""Test VerifiedHTTPSConnection: absence of SSL key file."""
161+
"""Test SSL certificate verification with valid CA certificate."""
162162
port = self.port
163163
url = 'https://127.0.0.1:%d' % port
164164
cacert = os.path.join(TEST_VAR_DIR, 'ca.crt')
@@ -175,7 +175,7 @@ def test_v2_requests_valid_cert_verification_no_compression(self, __):
175175

176176
@mock.patch('sys.stderr')
177177
def test_v2_requests_valid_cert_no_key(self, __):
178-
"""Test VerifiedHTTPSConnection: absence of SSL key file."""
178+
"""Test client cert authentication fails without private key."""
179179
port = self.port
180180
url = 'https://127.0.0.1:%d' % port
181181
cert_file = os.path.join(TEST_VAR_DIR, 'certificate.crt')
@@ -194,7 +194,7 @@ def test_v2_requests_valid_cert_no_key(self, __):
194194

195195
@mock.patch('sys.stderr')
196196
def test_v2_requests_bad_cert(self, __):
197-
"""Test VerifiedHTTPSConnection: absence of SSL key file."""
197+
"""Test client cert authentication fails with bad certificate."""
198198
port = self.port
199199
url = 'https://127.0.0.1:%d' % port
200200
cert_file = os.path.join(TEST_VAR_DIR, 'badcert.crt')
@@ -217,7 +217,7 @@ def test_v2_requests_bad_cert(self, __):
217217

218218
@mock.patch('sys.stderr')
219219
def test_v2_requests_bad_ca(self, __):
220-
"""Test VerifiedHTTPSConnection: absence of SSL key file."""
220+
"""Test SSL verification fails with invalid CA certificate path."""
221221
port = self.port
222222
url = 'https://127.0.0.1:%d' % port
223223
cacert = os.path.join(TEST_VAR_DIR, 'badca.crt')

0 commit comments

Comments
 (0)