Catch exceptions for interfaceStats in libvirt inspector

tobias-urdin · tobias-urdin · commit 87baa22317cd · 2025-09-01T15:32:49.000+02:00
In the Libvirt inspector we call the interfaceStats() function but there is a race between us checking if the domain is stopped and calling interfaceStats. This adds a try-catch around interfaceStats the same way as is already done for blockStats etc. Closes-Bug: #2113768 Change-Id: I25ba64f5eefe8140b45bc4ff7e20c323dc5efd79 (cherry picked from commit 70a56ba) Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>
diff --git a/ceilometer/compute/virt/libvirt/inspector.py b/ceilometer/compute/virt/libvirt/inspector.py
@@ -114,7 +114,13 @@ def inspect_vnics(self, instance, duration):
             params['interfaceid'] = interfaceid
             params['bridge'] = bridge
 
-            dom_stats = domain.interfaceStats(name)
+            try:
+                dom_stats = domain.interfaceStats(name)
+            except libvirt.libvirtError as ex:
+                LOG.warning(_("Error from libvirt when running instanceStats, "
+                              "This may not be harmful, but please check : "
+                              "%(ex)s") % {'ex': ex})
+                continue
 
             # Retrieve previous values
             prev = self.cache.get(name)
diff --git a/releasenotes/notes/bug-2113768-a2db3a59c8e13558.yaml b/releasenotes/notes/bug-2113768-a2db3a59c8e13558.yaml
@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Fixed `bug #2113768 <https://bugs.launchpad.net/ceilometer/+bug/2113768>`__ where
+    the Libvirt inspector did not catch exceptions thrown when calling interfaceStats
+    function on a domain.
