Skip to content

Fix decode issue for #191#192

Merged
fabianvf merged 1 commit into
openshift:masterfrom
muff1nman:master
Aug 2, 2018
Merged

Fix decode issue for #191#192
fabianvf merged 1 commit into
openshift:masterfrom
muff1nman:master

Conversation

@muff1nman
Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2018
@muff1nman
Copy link
Copy Markdown
Contributor Author

I tested this with read_image on python 2 and 3

@fabianvf
Copy link
Copy Markdown
Member

fabianvf commented Aug 2, 2018

@fridex since you were just working with this, mind giving it a look?

Copy link
Copy Markdown
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! This was my bad, I didn't realize a string is expected. 👍

@fabianvf fabianvf merged commit 76ac67f into openshift:master Aug 2, 2018
@fabianvf fabianvf mentioned this pull request Aug 2, 2018
willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Nov 22, 2018
willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Nov 22, 2019
jmrodri pushed a commit to jmrodri/openshift-restclient-python that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants