Add static constant to explain default and verify via unit test

bp-alex · bp-alex · commit 49f779597826 · 2018-12-20T14:03:41.000+11:00
diff --git a/src/main/java/org/lmdbjava/Env.java b/src/main/java/org/lmdbjava/Env.java
@@ -429,9 +429,10 @@ public AlreadyOpenException() {
    */
   public static final class Builder<T> {
 
+    static final int MAX_READERS_DEFAULT = 126;
     private long mapSize = 1_024 * 1_024;
     private int maxDbs = 1;
-    private int maxReaders = 126;
+    private int maxReaders = MAX_READERS_DEFAULT;
     private boolean opened;
     private final BufferProxy<T> proxy;
 
diff --git a/src/test/java/org/lmdbjava/EnvTest.java b/src/test/java/org/lmdbjava/EnvTest.java
@@ -333,6 +333,8 @@ public void stats() throws IOException {
   public void testDefaultOpen() throws IOException {
     final File path = tmp.newFolder();
     try (Env<ByteBuffer> env = open(path, 10)) {
+      final EnvInfo info = env.info();
+      assertThat(info.maxReaders, is(MAX_READERS_DEFAULT));
       final Dbi<ByteBuffer> db = env.openDbi("test", MDB_CREATE);
       db.put(allocateDirect(1), allocateDirect(1));
     }

Original file line number	Diff line number	Diff line change
`@@ -333,6 +333,8 @@ public void stats() throws IOException {`
`333`	`333`	`public void testDefaultOpen() throws IOException {`
`334`	`334`	`final File path = tmp.newFolder();`
`335`	`335`	`try (Env<ByteBuffer> env = open(path, 10)) {`
	`336`	`+ final EnvInfo info = env.info();`
	`337`	`+ assertThat(info.maxReaders, is(MAX_READERS_DEFAULT));`
`336`	`338`	`final Dbi<ByteBuffer> db = env.openDbi("test", MDB_CREATE);`
`337`	`339`	`db.put(allocateDirect(1), allocateDirect(1));`
`338`	`340`	`}`