Add pathlib support to fileish_open (dtcooper#101)

AartGoossens · pR0Ps · commit 52a6f01447a0 · 2020-12-20T13:30:34.000-05:00
diff --git a/fitparse/utils.py b/fitparse/utils.py
@@ -5,6 +5,12 @@
 except ImportError:
     from collections import Iterable
 
+try:
+    # Python 3.4+
+    from pathlib import PurePath
+except ImportError:
+    PurePath = None
+
 
 class FitParseError(ValueError):
     pass
@@ -56,9 +62,13 @@ def fileish_open(fileish, mode):
             return open(fileish, mode)
         except TypeError:
             return io.BytesIO(fileish)
-    else:
-        # Python 3 - file contents
-        return io.BytesIO(fileish)
+
+    # Python 3 - pathlib obj
+    if PurePath and isinstance(fileish, PurePath):
+        return fileish.open(mode)
+
+    # Python 3 - file contents
+    return io.BytesIO(fileish)
 
 
 def is_iterable(obj):
diff --git a/tests/test_utils.py b/tests/test_utils.py
@@ -5,6 +5,12 @@
 import sys
 import tempfile
 
+try:
+    # Python 3.4+
+    from pathlib import Path
+except ImportError:
+    Path = None
+
 from fitparse.utils import fileish_open, is_iterable
 
 if sys.version_info >= (2, 7):
@@ -38,6 +44,8 @@ def test_fopen(fileish):
             test_fopen(f.read())
         with open(testfile("nametest.FIT"), 'rb') as f:
             test_fopen(io.BytesIO(f.read()))
+        if Path:
+            test_fopen(Path(testfile('nametest.FIT')))
 
     def test_fileish_open_write(self):
 
