Skip to content

Commit 22c7b58

Browse files
franciscojavierarceofranciscojavierarceo
authored
feat: Add Milvus Vector Database Implementation (feast-dev#4751)
1 parent 18ff604 commit 22c7b58

9 files changed

Lines changed: 505 additions & 24 deletions

File tree

‎.github/workflows/pr_local_integration_tests.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
uses: actions/cache@v4
5151
with:
5252
path: ${{ steps.uv-cache.outputs.dir }}
53-
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', env.PYTHON)) }}
53+
key: ${{ runner.os }}-${{ matrix.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', matrix.python-version)) }}
5454
- name: Install dependencies
5555
run: make install-python-dependencies-ci
5656
- name: Test local integration tests

‎Makefile‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ test-python-universal-postgres-online:
268268
not test_snowflake" \
269269
sdk/python/tests
270270

271-
test-python-universal-mysql-online:
271+
test-python-universal-mysql-online:
272272
PYTHONPATH='.' \
273273
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.mysql_online_store.mysql_repo_configuration \
274274
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.mysql \
@@ -292,7 +292,11 @@ test-python-universal-cassandra:
292292
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.cassandra_online_store.cassandra_repo_configuration \
293293
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.cassandra \
294294
python -m pytest -x --integration \
295-
sdk/python/tests
295+
sdk/python/tests/integration/offline_store/test_feature_logging.py \
296+
--ignore=sdk/python/tests/integration/offline_store/test_validation.py \
297+
-k "not test_snowflake and \
298+
not test_spark_materialization_consistency and \
299+
not test_universal_materialization"
296300

297301
test-python-universal-hazelcast:
298302
PYTHONPATH='.' \
@@ -330,7 +334,7 @@ test-python-universal-cassandra-no-cloud-providers:
330334
not test_snowflake" \
331335
sdk/python/tests
332336

333-
test-python-universal-elasticsearch-online:
337+
test-python-universal-elasticsearch-online:
334338
PYTHONPATH='.' \
335339
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.elasticsearch_online_store.elasticsearch_repo_configuration \
336340
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.elasticsearch \
@@ -349,6 +353,14 @@ test-python-universal-cassandra-no-cloud-providers:
349353
not test_snowflake" \
350354
sdk/python/tests
351355

356+
test-python-universal-milvus-online:
357+
PYTHONPATH='.' \
358+
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.milvus_online_store.milvus_repo_configuration \
359+
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.milvus \
360+
python -m pytest -n 8 --integration \
361+
-k "test_retrieve_online_milvus_ocuments" \
362+
sdk/python/tests --ignore=sdk/python/tests/integration/offline_store/test_dqm_validation.py
363+
352364
test-python-universal-singlestore-online:
353365
PYTHONPATH='.' \
354366
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.singlestore_repo_configuration \

‎docs/how-to-guides/customizing-feast/adding-support-for-a-new-online-store.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ OnlineStore class names must end with the OnlineStore suffix!
2525

2626
### Contrib online stores
2727

28-
New online stores go in `sdk/python/feast/infra/online_stores/contrib/`.
28+
New online stores go in `sdk/python/feast/infra/online_stores/`.
2929

3030
#### What is a contrib plugin?
3131

‎sdk/python/docs/source/feast.infra.online_stores.milvus_online_store.rst‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,14 @@ feast.infra.online\_stores.milvus\_online\_store package
44
Submodules
55
----------
66

7+
feast.infra.online\_stores.milvus\_online\_store.milvus module
8+
--------------------------------------------------------------
9+
10+
.. automodule:: feast.infra.online_stores.milvus_online_store.milvus
11+
:members:
12+
:undoc-members:
13+
:show-inheritance:
14+
715
feast.infra.online\_stores.milvus\_online\_store.milvus\_repo\_configuration module
816
-----------------------------------------------------------------------------------
917

0 commit comments

Comments
 (0)