Assert String-key setAttribute overloads in shared default logger test#8567
Draft
thswlsqls wants to merge 1 commit into
Draft
Assert String-key setAttribute overloads in shared default logger test#8567thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8567 +/- ##
=========================================
Coverage 91.55% 91.55%
Complexity 10262 10262
=========================================
Files 1013 1013
Lines 27102 27102
Branches 3182 3182
=========================================
Hits 24812 24812
Misses 1565 1565
Partials 725 725 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AbstractDefaultLoggerTest.buildAndEmit()only exercised theAttributeKey-typedsetAttribute, so the six String-keyLogRecordBuilderoverloads (String, long, int, double, boolean,Value) never ran through the noop delegation path.LogRecordBuilderattribute surface.AbstractDefaultTracerTest, which already exercises every String-keySpanBuilderoverload.Testing done
./gradlew :api:testing-internal:check— passed../gradlew :api:all:test --tests DefaultLoggerTest— 3 passed../gradlew :api:incubator:test --tests ExtendedDefaultLoggerTest— 4 passed.