squid:S1186 - Methods should not be empty

Mohammed Ezzat · Mohammed Ezzat · commit df4a40fc1338 · 2016-02-03T21:51:40.000+02:00
diff --git a/null-object/src/main/java/com/iluwatar/nullobject/NullNode.java b/null-object/src/main/java/com/iluwatar/nullobject/NullNode.java
@@ -60,5 +60,7 @@ public String getName() {
   }
 
   @Override
-  public void walk() {}
+  public void walk() {
+    // Do nothing
+  }
 }
diff --git a/visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java b/visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java
@@ -30,10 +30,14 @@
 public class CommanderVisitor implements UnitVisitor {
 
   @Override
-  public void visitSoldier(Soldier soldier) {}
+  public void visitSoldier(Soldier soldier) {
+    // Do nothing
+  }
 
   @Override
-  public void visitSergeant(Sergeant sergeant) {}
+  public void visitSergeant(Sergeant sergeant) {
+    // Do nothing
+  }
 
   @Override
   public void visitCommander(Commander commander) {
diff --git a/visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java b/visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java
@@ -30,13 +30,17 @@
 public class SergeantVisitor implements UnitVisitor {
 
   @Override
-  public void visitSoldier(Soldier soldier) {}
+  public void visitSoldier(Soldier soldier) {
+    // Do nothing
+  }
 
   @Override
   public void visitSergeant(Sergeant sergeant) {
     System.out.println("Hello " + sergeant);
   }
 
   @Override
-  public void visitCommander(Commander commander) {}
+  public void visitCommander(Commander commander) {
+    // Do nothing
+  }
 }
diff --git a/visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java b/visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java
@@ -35,8 +35,12 @@ public void visitSoldier(Soldier soldier) {
   }
 
   @Override
-  public void visitSergeant(Sergeant sergeant) {}
+  public void visitSergeant(Sergeant sergeant) {
+    // Do nothing
+  }
 
   @Override
-  public void visitCommander(Commander commander) {}
+  public void visitCommander(Commander commander) {
+    // Do nothing
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -60,5 +60,7 @@ public String getName() {`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`@Override`
`63`		`- public void walk() {}`
	`63`	`+ public void walk() {`
	`64`	`+ // Do nothing`
	`65`	`+ }`
`64`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,12 @@ public void visitSoldier(Soldier soldier) {`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`@Override`
`38`		`- public void visitSergeant(Sergeant sergeant) {}`
	`38`	`+ public void visitSergeant(Sergeant sergeant) {`
	`39`	`+ // Do nothing`
	`40`	`+ }`
`39`	`41`
`40`	`42`	`@Override`
`41`		`- public void visitCommander(Commander commander) {}`
	`43`	`+ public void visitCommander(Commander commander) {`
	`44`	`+ // Do nothing`
	`45`	`+ }`
`42`	`46`	`}`