iluwatar#587 SonarQube reports bugs

mookkiah · mookkiah · commit 2a7feba42787 · 2017-08-18T14:18:43.000-04:00
As recommended in https://sonarcloud.io/organizations/default/rules#rule_key=squid%3AS2274 Used while insteadof if - for waiting upon a condition.
diff --git a/async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/ThreadAsyncExecutor.java b/async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/ThreadAsyncExecutor.java
@@ -139,7 +139,7 @@ public T getValue() throws ExecutionException {
     @Override
     public void await() throws InterruptedException {
       synchronized (lock) {
-        if (!isCompleted()) {
+        while (!isCompleted()) {
           lock.wait();
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ public T getValue() throws ExecutionException {`
`139`	`139`	`@Override`
`140`	`140`	`public void await() throws InterruptedException {`
`141`	`141`	`synchronized (lock) {`
`142`		`- if (!isCompleted()) {`
	`142`	`+ while (!isCompleted()) {`
`143`	`143`	`lock.wait();`
`144`	`144`	`}`
`145`	`145`	`}`