Skip to content

Commit 16abbe8

Browse files
committed
Python3 compatibility initial commit (after 2to3 run)
1 parent cb3401e commit 16abbe8

5 files changed

Lines changed: 18 additions & 18 deletions

File tree

src/etcd/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import collections
2-
from client import Client
2+
from .client import Client
33

44
class EtcdResult(collections.namedtuple(
55
'EtcdResult',

src/etcd/client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ def write(self, key, value, ttl=None, **kwdargs):
234234
if ttl:
235235
params['ttl'] = ttl
236236

237-
for (k,v) in kwdargs.iteritems():
237+
for (k,v) in kwdargs.items():
238238
if k in self._comparison_conditions:
239239
if type(v) == bool:
240240
params[k] = v and "true" or "false"
@@ -273,7 +273,7 @@ def read(self, key, **kwdargs):
273273
274274
"""
275275
params = {}
276-
for (k,v) in kwdargs.iteritems():
276+
for (k,v) in kwdargs.items():
277277
if k in self._read_options:
278278
if type(v) == bool:
279279
params[k] = v and "true" or "false"
@@ -421,7 +421,7 @@ def _result_from_response(self, response):
421421
if response.status == 201:
422422
res['newKey'] = True
423423
return etcd.EtcdResult(**res)
424-
except Exception, e:
424+
except Exception as e:
425425
raise etcd.EtcdException('Unable to decode server response: %s' % e)
426426

427427
def _next_server(self):

src/etcd/tests/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
import unit
1+
from . import unit

src/etcd/tests/integration/test_simple.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import urllib3
1010

1111
import etcd
12-
import helpers
12+
from . import helpers
1313

1414
from nose.tools import nottest
1515

@@ -74,7 +74,7 @@ def test_get_set_delete(self):
7474
try:
7575
get_result = self.client.get('/test_set')
7676
assert False
77-
except KeyError, e:
77+
except KeyError as e:
7878
pass
7979

8080
self.assertFalse('/test_set' in self.client)
@@ -101,7 +101,7 @@ def test_get_set_delete(self):
101101
try:
102102
get_result = self.client.get('/test_set')
103103
assert False
104-
except KeyError, e:
104+
except KeyError as e:
105105
pass
106106

107107
def test_retrieve_subkeys(self):
@@ -124,7 +124,7 @@ def test_is_not_a_file(self):
124124
try:
125125
get_result = self.client.set('/directory', 'test-value')
126126
assert False
127-
except KeyError, e:
127+
except KeyError as e:
128128
pass
129129

130130
def test_test_and_set(self):
@@ -144,7 +144,7 @@ def test_test_and_set(self):
144144
'old-test-value')
145145

146146
assert False
147-
except ValueError, e:
147+
except ValueError as e:
148148
pass
149149

150150

@@ -454,14 +454,14 @@ def test_get_set_unauthenticated(self):
454454
set_result = client.set('/test_set', 'test-key')
455455
self.fail()
456456

457-
except etcd.EtcdException, e:
457+
except etcd.EtcdException as e:
458458
self.assertTrue(e.message.startswith("Unable to decode server response"))
459459

460460
try:
461461
get_result = client.get('/test_set')
462462
self.fail()
463463

464-
except etcd.EtcdException, e:
464+
except etcd.EtcdException as e:
465465
self.assertTrue(e.message.startswith("Unable to decode server response"))
466466

467467
def test_get_set_unauthenticated_missing_ca(self):
@@ -480,12 +480,12 @@ def test_get_set_unauthenticated_with_ca(self):
480480
try:
481481
set_result = client.set('/test_set', 'test-key')
482482
assert False
483-
except urllib3.exceptions.SSLError, e:
483+
except urllib3.exceptions.SSLError as e:
484484
assert True
485485

486486
try:
487487
get_result = client.get('/test_set')
488-
except urllib3.exceptions.SSLError, e:
488+
except urllib3.exceptions.SSLError as e:
489489
assert True
490490

491491
def test_get_set_authenticated(self):
@@ -554,14 +554,14 @@ def test_get_set_unauthenticated(self):
554554
set_result = client.set('/test_set', 'test-key')
555555
self.fail()
556556

557-
except etcd.EtcdException, e:
557+
except etcd.EtcdException as e:
558558
self.assertTrue(e.message.startswith("Unable to decode server response"))
559559

560560
try:
561561
get_result = client.get('/test_set')
562562
self.fail()
563563

564-
except etcd.EtcdException, e:
564+
except etcd.EtcdException as e:
565565
self.assertTrue(e.message.startswith("Unable to decode server response"))
566566

567567
def test_get_set_authenticated(self):

src/etcd/tests/unit/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
import test_client
2-
import test_request
1+
from . import test_client
2+
from . import test_request

0 commit comments

Comments
 (0)