Merge pull request #288 from DevFactory/release/adding-private-constructor-fix-1

stickfigure · stickfigure · commit 1ebf15a03bb6 · 2016-03-17T11:47:19.000-07:00
Utility classes should not have public constructors
diff --git a/src/main/java/com/googlecode/objectify/cache/CachingDatastoreServiceFactory.java b/src/main/java/com/googlecode/objectify/cache/CachingDatastoreServiceFactory.java
@@ -19,7 +19,10 @@
 public class CachingDatastoreServiceFactory
 {
 	private static String defaultMemcacheNamespace = ObjectifyFactory.MEMCACHE_NAMESPACE;
-	
+
+	private CachingDatastoreServiceFactory() {
+	}
+
 	/** 
 	 * The default namespace is the one used by Objectify for its cache.  You can reset it.
 	 */
diff --git a/src/main/java/com/googlecode/objectify/impl/TypeUtils.java b/src/main/java/com/googlecode/objectify/impl/TypeUtils.java
@@ -27,6 +27,9 @@ public class TypeUtils
 		PRIMITIVE_TO_WRAPPER.put(char.class, Character.class);
 	}
 
+	private TypeUtils() {
+	}
+
 	/**
 	 * Throw an IllegalStateException if the class does not have a no-arg constructor.
 	 */
diff --git a/src/main/java/com/googlecode/objectify/impl/translate/opt/joda/JodaMoneyTranslators.java b/src/main/java/com/googlecode/objectify/impl/translate/opt/joda/JodaMoneyTranslators.java
@@ -15,6 +15,9 @@
  */
 public class JodaMoneyTranslators
 {
+	private JodaMoneyTranslators() {
+	}
+
 	public static void add(ObjectifyFactory fact) {
 		fact.getTranslators().add(new MoneyStringTranslatorFactory());
 		fact.getTranslators().add(new BigMoneyStringTranslatorFactory());
diff --git a/src/main/java/com/googlecode/objectify/impl/translate/opt/joda/JodaTimeTranslators.java b/src/main/java/com/googlecode/objectify/impl/translate/opt/joda/JodaTimeTranslators.java
@@ -15,6 +15,9 @@
  */
 public class JodaTimeTranslators
 {
+	private JodaTimeTranslators() {
+	}
+
 	public static void add(ObjectifyFactory fact) {
 		fact.getTranslators().add(new ReadableInstantTranslatorFactory());
 		fact.getTranslators().add(new ReadablePartialTranslatorFactory());
diff --git a/src/main/java/com/googlecode/objectify/repackaged/gentyref/GenericTypeReflector.java b/src/main/java/com/googlecode/objectify/repackaged/gentyref/GenericTypeReflector.java
@@ -21,7 +21,10 @@
  */
 public class GenericTypeReflector {
 	private static final Type UNBOUND_WILDCARD = new WildcardTypeImpl(new Type[]{Object.class}, new Type[]{});
-	
+
+	private GenericTypeReflector() {
+	}
+
 	/**
 	 * Returns the erasure of the given type.
 	 */
diff --git a/src/main/java/com/googlecode/objectify/repackaged/gentyref/TypeFactory.java b/src/main/java/com/googlecode/objectify/repackaged/gentyref/TypeFactory.java
@@ -15,7 +15,10 @@
  */
 public class TypeFactory {
 	private static final WildcardType UNBOUND_WILDCARD = new WildcardTypeImpl(new Type[]{Object.class}, new Type[]{});
-	
+
+	private TypeFactory() {
+	}
+
 	/**
 	 * Creates a type of class <tt>clazz</tt> with <tt>arguments</tt> as type arguments.
 	 * <p>
diff --git a/src/main/java/com/googlecode/objectify/util/DatastoreIntrospector.java b/src/main/java/com/googlecode/objectify/util/DatastoreIntrospector.java
@@ -39,4 +39,7 @@ public class DatastoreIntrospector
 			}
 		}
 	}
+
+	private DatastoreIntrospector() {
+	}
 }
diff --git a/src/main/java/com/googlecode/objectify/util/DatastoreUtils.java b/src/main/java/com/googlecode/objectify/util/DatastoreUtils.java
@@ -19,6 +19,9 @@
  */
 public class DatastoreUtils
 {
+	private DatastoreUtils() {
+	}
+
 	/**
 	 * Turn a list of refs into a list of raw keys.
 	 */
diff --git a/src/main/java/com/googlecode/objectify/util/FutureHelper.java b/src/main/java/com/googlecode/objectify/util/FutureHelper.java
@@ -18,6 +18,9 @@
  */
 public class FutureHelper
 {
+	private FutureHelper() {
+	}
+
 	/** Quietly perform the get() on a future */
 	public static <T> T quietGet(Future<T> future)
 	{
diff --git a/src/main/java/com/googlecode/objectify/util/GenericUtils.java b/src/main/java/com/googlecode/objectify/util/GenericUtils.java
@@ -10,6 +10,9 @@
  */
 public class GenericUtils
 {
+	private GenericUtils() {
+	}
+
 	/**
 	 * Get the component type of a Collection.
 	 */
diff --git a/src/main/java/com/googlecode/objectify/util/LogUtils.java b/src/main/java/com/googlecode/objectify/util/LogUtils.java
@@ -14,7 +14,10 @@ public class LogUtils
 {
 	/** */
 	static final int PATH_PADDING = 13;
-	
+
+	private LogUtils() {
+	}
+
 	/** Create a log a message for a given path */
 	public static String msg(Path path, String msg) {
 		StringBuilder bld = new StringBuilder();

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,9 @@ public class TypeUtils`
`27`	`27`	`PRIMITIVE_TO_WRAPPER.put(char.class, Character.class);`
`28`	`28`	`}`
`29`	`29`
	`30`	`+ private TypeUtils() {`
	`31`	`+ }`
	`32`	`+`
`30`	`33`	`/**`
`31`	`34`	`* Throw an IllegalStateException if the class does not have a no-arg constructor.`
`32`	`35`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -39,4 +39,7 @@ public class DatastoreIntrospector`
`39`	`39`	`}`
`40`	`40`	`}`
`41`	`41`	`}`
	`42`	`+`
	`43`	`+ private DatastoreIntrospector() {`
	`44`	`+ }`
`42`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,9 @@`
`18`	`18`	`*/`
`19`	`19`	`public class FutureHelper`
`20`	`20`	`{`
	`21`	`+ private FutureHelper() {`
	`22`	`+ }`
	`23`	`+`
`21`	`24`	`/** Quietly perform the get() on a future */`
`22`	`25`	`public static <T> T quietGet(Future<T> future)`
`23`	`26`	`{`