Fix dirname so that dirname('/a/b/') -> '/a', like sh's does.

isaacs · ry · commit f0f247d7e5bd · 2010-07-23T09:08:49.000-07:00
Before there was this comment:
  Can't strip trailing slashes since module.js incorrectly
  thinks dirname('/a/b/') should yield '/a/b' instead of '/a'.
But now, such thinking is corrected.
diff --git a/lib/module.js b/lib/module.js
@@ -197,7 +197,7 @@ function resolveModulePath(request, parent) {
     }
 
     var parentIdPath = path.dirname(parent.id +
-      (path.basename(parent.filename).match(new RegExp('^index\\.(' + exts.join('|') + ')$')) ? "/" : ""));
+      (path.basename(parent.filename).match(new RegExp('^index\\.(' + exts.join('|') + ')$')) ? "/." : ""));
     id = path.join(parentIdPath, request);
     // make sure require('./path') and require('path') get distinct ids, even
     // when called from the toplevel js file
diff --git a/lib/path.js b/lib/path.js
@@ -38,11 +38,9 @@ exports.normalize = function (path, keepBlanks) {
 };
 
 exports.dirname = function (path) {
-  // Can't strip trailing slashes since module.js incorrectly thinks
-  // dirname('/a/b/') should yield '/a/b' instead of '/a'.
-  // if (path.length > 1 && '/' === path[path.length-1]) {
-  //  path = path.replace(/\/+$/, '');
-  // }
+  if (path.length > 1 && '/' === path[path.length-1]) {
+    path = path.replace(/\/+$/, '');
+  }
   var lastSlash = path.lastIndexOf('/');
   switch (lastSlash) {
     case -1:
diff --git a/test/simple/test-path.js b/test/simple/test-path.js
@@ -8,6 +8,7 @@ assert.equal(path.basename(f), "test-path.js");
 assert.equal(path.basename(f, ".js"), "test-path");
 assert.equal(path.extname(f), ".js");
 assert.equal(path.dirname(f).substr(-11), "test/simple");
+assert.equal(path.dirname("/a/b/"), "/a");
 assert.equal(path.dirname("/a/b"), "/a");
 assert.equal(path.dirname("/a"), "/");
 assert.equal(path.dirname("/"), "/");

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ function resolveModulePath(request, parent) {`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`var parentIdPath = path.dirname(parent.id +`
`200`		`- (path.basename(parent.filename).match(new RegExp('^index\\.(' + exts.join('\|') + ')$')) ? "/" : ""));`
	`200`	`+ (path.basename(parent.filename).match(new RegExp('^index\\.(' + exts.join('\|') + ')$')) ? "/." : ""));`
`201`	`201`	`id = path.join(parentIdPath, request);`
`202`	`202`	`// make sure require('./path') and require('path') get distinct ids, even`
`203`	`203`	`// when called from the toplevel js file`