Skip to content

gin-server support#385

Closed
TheTeaParty wants to merge 4 commits intooapi-codegen:mainfrom
TheTeaParty:feat/gin-server
Closed

gin-server support#385
TheTeaParty wants to merge 4 commits intooapi-codegen:mainfrom
TheTeaParty:feat/gin-server

Conversation

@TheTeaParty
Copy link
Copy Markdown

Closes #384

@stephen-opal
Copy link
Copy Markdown

I'd love to use this!

}
{{end}}
{{if .IsStyled}}
err = runtime.BindStyledParameter("{{.Style}}",{{.Explode}}, "{{.ParamName}}", c.Query("{{.ParamName}}"), &{{$varName}})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be c.Param not c.Query?

for _, middleware := range siw.HandlerMiddlewares {
middleware(c)
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you want a IsAborted check to prevent the handler from being executed if the middleware aborts?

@Ehco1996
Copy link
Copy Markdown
Contributor

@TheTeaParty

Thanks for your great contribution, any update about this PR ?
Maybe I can get involved too, if you agree

@rdnt
Copy link
Copy Markdown

rdnt commented Sep 29, 2021

Hi @TheTeaParty, is this PR still active?

@ghost
Copy link
Copy Markdown

ghost commented Sep 30, 2021

Hi guys,

I am be really interested by this PR ^^

What are the blocking points ?

Cheers,
Luc Michalski

Comment thread pkg/codegen/codegen.go

// Options defines the optional code to generate.
type Options struct {
GenerateGinServer bool // GenerateChiServer specifies whether to generate chi server boilerplate
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. GenerateChiServer should be GenerateGinServer

Comment thread pkg/codegen/operations.go
return buf.String(), nil
}

// GenerateChiServer This function generates all the go code for the ServerInterface as well as
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. GenerateChiServer should be GenerateGinServer

@erikbos
Copy link
Copy Markdown

erikbos commented Oct 31, 2021

@TheTeaParty Great PR, love to see it merged in.. any work pending?

@Ehco1996 Ehco1996 mentioned this pull request Nov 2, 2021
2 tasks
@Ehco1996
Copy link
Copy Markdown
Contributor

Ehco1996 commented Nov 2, 2021

@erikbos @rdnt @lucmichalski

#475 was merged into master with gin support

@jamietanna
Copy link
Copy Markdown
Member

Thanks for this! Just doing some cleanup, and it's now part of the library, although we didn't get around to using your contribution

@jamietanna jamietanna closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gin-server support

6 participants