From 2e2766c23a0081a89cbfba1d826c76b2bd3702d1 Mon Sep 17 00:00:00 2001 From: Jamie Tanna Date: Thu, 28 Nov 2024 11:36:10 +0000 Subject: [PATCH] build: ensure separately named "Check results" steps This makes sure these are now 4 separate checks, which can be independently added, which ensures that all stages run successfully before an auto-merge applies. Previously, we've had cases where a PR can be automerged before all checks execute, as GitHub sees that one of the `Check results` steps has passed, and expects all of them have. --- .github/workflows/ci.yml | 2 +- .github/workflows/generate.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/tidy.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f1d7d02d55..7b57f0be1a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -33,7 +33,7 @@ jobs: results: if: ${{ always() }} runs-on: ubuntu-latest - name: Check results + name: Check build results needs: [build] steps: - run: | diff --git a/.github/workflows/generate.yml b/.github/workflows/generate.yml index 588f63411e..51f8490a31 100644 --- a/.github/workflows/generate.yml +++ b/.github/workflows/generate.yml @@ -33,7 +33,7 @@ jobs: results: if: ${{ always() }} runs-on: ubuntu-latest - name: Check results + name: Check generation results needs: [build] steps: - run: | diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 07cdf5d6c8..49c0b1a07f 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -30,7 +30,7 @@ jobs: results: if: ${{ always() }} runs-on: ubuntu-latest - name: Check results + name: Check linting results needs: [build] steps: - run: | diff --git a/.github/workflows/tidy.yml b/.github/workflows/tidy.yml index cd96670676..7c661110b6 100644 --- a/.github/workflows/tidy.yml +++ b/.github/workflows/tidy.yml @@ -33,7 +33,7 @@ jobs: results: if: ${{ always() }} runs-on: ubuntu-latest - name: Check results + name: Check tidy results needs: [build] steps: - run: |