fix: add x-go-name for server urls (#2304)

dhpollack · greptile-apps[bot] · web-flow · commit 9aeaed3ce776 · 2026-04-08T10:03:52.000-07:00
* fix: add x-go-name for server urls

* Update pkg/codegen/server_urls.go

do not swallow the extGoName error from automated review bot

Co-authored-by: greptile-apps[bot] &lt;165735046+greptile-apps[bot]@users.noreply.github.com&gt;

---------

Co-authored-by: greptile-apps[bot] &lt;165735046+greptile-apps[bot]@users.noreply.github.com&gt;
diff --git a/examples/generate/serverurls/api.yaml b/examples/generate/serverurls/api.yaml
@@ -45,3 +45,7 @@ servers:
   description: some lowercase name
 # there may be URLs on their own, without a `description`
 - url: http://localhost:443
+# x-go-name overrides the auto-generated Go name
+- url: https://api.example.com/v2
+  description: Custom named server
+  x-go-name: MyCustomAPIServer
diff --git a/examples/generate/serverurls/gen.go b/examples/generate/serverurls/gen.go
diff --git a/examples/generate/serverurls/gen_test.go b/examples/generate/serverurls/gen_test.go
@@ -46,3 +46,9 @@ func TestServerUrlTheProductionAPIServer(t *testing.T) {
 		assert.Equal(t, "https://demo.gigantic-server.com:8443/v2", serverUrl)
 	})
 }
+
+func TestXGoName(t *testing.T) {
+	t.Run("x-go-name overrides the auto-generated server name", func(t *testing.T) {
+		assert.Equal(t, "https://api.example.com/v2", MyCustomAPIServer)
+	})
+}
diff --git a/pkg/codegen/server_urls.go b/pkg/codegen/server_urls.go
@@ -24,12 +24,24 @@ func GenerateServerURLs(t *template.Template, spec *openapi3.T) (string, error)
 	names := make(map[string]*openapi3.Server)
 
 	for _, server := range spec.Servers {
-		suffix := server.Description
-		if suffix == "" {
-			suffix = nameNormalizer(server.URL)
+		var name string
+		if goNameExt, ok := server.Extensions[extGoName]; ok {
+			customName, err := extParseGoFieldName(goNameExt)
+			if err != nil {
+				return "", fmt.Errorf("invalid value for %q: %w", extGoName, err)
+			}
+			if customName != "" {
+				name = customName
+			}
+		}
+		if name == "" {
+			suffix := server.Description
+			if suffix == "" {
+				suffix = nameNormalizer(server.URL)
+			}
+			name = serverURLPrefix + UppercaseFirstCharacter(suffix)
+			name = nameNormalizer(name)
 		}
-		name := serverURLPrefix + UppercaseFirstCharacter(suffix)
-		name = nameNormalizer(name)
 
 		// if this is the only type with this name, store it
 		if _, conflict := names[name]; !conflict {
