test: add Pattern I for inline response with x-go-type $ref properties

mromaszewicz · claude · mromaszewicz · commit 98dfe0397e1e · 2026-02-13T08:28:28.000-08:00
Add test case from oapi-codegen-exp#14: an inline response object whose
properties $ref component schemas with x-go-type: string. In the
experimental rewrite (libopenapi), this caused duplicate type declarations
because libopenapi copies extensions from $ref targets. V2 (kin-openapi)
handles this correctly, but the test guards against future regressions.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/internal/test/name_conflict_resolution/name_conflict_resolution.gen.go b/internal/test/name_conflict_resolution/name_conflict_resolution.gen.go
diff --git a/internal/test/name_conflict_resolution/name_conflict_resolution_test.go b/internal/test/name_conflict_resolution/name_conflict_resolution_test.go
@@ -291,6 +291,28 @@ func TestExtGoTypeWithCollisionResolver(t *testing.T) {
 	assert.Equal(t, "response-result", *wrapper.JSON200.Result)
 }
 
+// TestInlineResponseWithRefProperties verifies Pattern I (oapi-codegen-exp#14):
+// when a response has an inline object whose properties contain $refs to component
+// schemas with x-go-type, the property-level refs must NOT produce duplicate type
+// declarations. The component schemas keep their type aliases (Widget = string,
+// Metadata = string), and the inline response object gets its own struct type.
+//
+// Covers: oapi-codegen-exp#14
+func TestInlineResponseWithRefProperties(t *testing.T) {
+	// Component schemas with x-go-type: string produce type aliases
+	var widget Widget = "widget-value"
+	assert.Equal(t, "widget-value", string(widget))
+
+	var metadata Metadata = "metadata-value"
+	assert.Equal(t, "metadata-value", string(metadata))
+
+	// The inline response object should have fields typed by the component aliases.
+	// The client wrapper for listEntities should exist and have a JSON200 field
+	// pointing to the inline response type.
+	var wrapper ListEntitiesResponse
+	assert.Nil(t, wrapper.JSON200)
+}
+
 func ptr[T any](v T) *T {
 	return &v
 }
diff --git a/internal/test/name_conflict_resolution/spec.yaml b/internal/test/name_conflict_resolution/spec.yaml
@@ -5,6 +5,7 @@ info:
   description: |
     Exercises all documented name collision patterns across issues and PRs:
     #200, #254, #255, #292, #407, #899, #1357, #1450, #1474, #1713, #1881, #2097, #2213
+    Also covers oapi-codegen-exp#14 (inline response object with $ref properties).
   version: 0.0.0
 
 paths:
@@ -149,6 +150,28 @@ paths:
               schema:
                 $ref: '#/components/schemas/Order'
 
+  # Pattern I: Inline response object with $ref properties to x-go-type schemas
+  # (oapi-codegen-exp#14). The response has an inline object with properties that
+  # $ref component schemas carrying x-go-type. Each property ref should use the
+  # component schema's type alias, not produce duplicate type declarations.
+  /entities:
+    get:
+      operationId: listEntities
+      responses:
+        '200':
+          description: OK
+          content:
+            application/json:
+              schema:
+                type: object
+                properties:
+                  data:
+                    type: array
+                    items:
+                      $ref: '#/components/schemas/Widget'
+                  metadata:
+                    $ref: '#/components/schemas/Metadata'
+
   # Cross-section: requestBody vs schema (issues #254, #407)
   # "Pet" appears in both schemas and requestBodies.
   /pets:
@@ -223,6 +246,22 @@ components:
         name:
           type: string
 
+    # Pattern I: schemas with x-go-type used as $ref targets in inline response properties.
+    # (oapi-codegen-exp#14)
+    Widget:
+      type: object
+      x-go-type: string
+      properties:
+        id:
+          type: string
+
+    Metadata:
+      type: object
+      x-go-type: string
+      properties:
+        total:
+          type: integer
+
     # Pattern F: x-go-type-name extension + cross-section collision
     # Schema "Qux" has x-go-type-name: CustomQux and collides with response "Qux".
     Qux:
