Commit 603e70f
support optional/nullable response headers
Closes: #2267
Response headers in strict server code were always generated as direct
value types regardless of whether they were required. This adds support
for optional and nullable response headers in the strict-interface and
strict-responses templates.
Add Required and Nullable fields to ResponseHeaderDefinition, populated
from the OpenAPI header object. Add GoTypeDef(), IsOptional(), and
IsNullable() methods that mirror the existing Property logic for
determining whether a field should be a pointer, nullable.Nullable[T],
or a direct value.
Update strict-interface.tmpl and strict-responses.tmpl to use GoTypeDef
for struct field types, and to conditionally guard w.Header().Set()
calls with nil/IsSpecified checks for optional/nullable headers.
Note: this is a breaking change for specs where response headers lack
explicit `required: true`, since the OpenAPI default is false. Existing
headers will change from direct values to pointers. This may need to be
gated behind a config option.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent a3a04d4 commit 603e70f
13 files changed
Lines changed: 301 additions & 159 deletions
File tree
- internal/test
- issues
- issue-1676
- issue-head-digit-of-httpheader
- strict-server
- chi
- echo
- fiber
- gin
- gorilla
- iris
- stdhttp
- pkg/codegen
- templates/strict
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments