Skip to content

MacOS test failure #4841

Closed
Closed

Description

@manfred-brands

We recently have build failures for the MacOS build on:

 Failed : NUnit.Framework.Tests.Constraints.DelayedConstraintTests.AssertionExpectingAnExceptionWithRetrySucceeds
  Assert.That(ThrowsAfterRetry, Throws.InvalidOperationException.After(AFTER, POLLING))
  Expected: <System.InvalidOperationException> after 500 milliseconds delay
  But was:  no exception thrown
   at NUnit.Framework.Tests.Constraints.DelayedConstraintTests.AssertionExpectingAnExceptionWithRetrySucceeds() in /_/src/NUnitFramework/tests/Constraints/DelayedConstraintTests.cs:line 256

Even though the async version was changed recently, this one was not.
Is there any one with a MacOS to see what this could be?
All I can think of is that the 50ms interval on MacOS is soo large that it doesn't do 4 iterations in 500ms.

Activity

  1. Dreamescaper commented on Sep 27, 2024

    @Dreamescaper
    Member

    There are multiple tests in that class, ignored for MacOS:
    Platform(Exclude = "MACOSX", Reason = "Doesn't seem to work correctly with timing, something to ponder later")]

  2. manfred-brands commented on Sep 27, 2024

    @manfred-brands
    MemberAuthor

    There is one ;-)
    But as none of use seem to have any (virtual) MacOS, the pondering is likely not happening.
    It might also have nothing to do with MacOS, but the github runner might be the culprit.
    We are not the only ones: actions/runner-images#1336
    It also seems that the macos runners are arm64: actions/runner-images#9741

    It also seems to run in half the memory:
    From: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners

    image

  3. added this to the 4.3 milestone on Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions