Add a 'focus' even to text input fields (NativeScript#4730)

EddyVerbruggen · Hristo Hristov · commit f00ec1a9666e · 2017-08-25T11:22:47.000+03:00
diff --git a/tns-core-modules/ui/editable-text-base/editable-text-base-common.ts b/tns-core-modules/ui/editable-text-base/editable-text-base-common.ts
@@ -5,6 +5,7 @@ export * from "../text-base";
 
 export abstract class EditableTextBase extends TextBase implements EditableTextBaseDefinition {
     public static blurEvent = "blur";
+    public static focusEvent = "focus";
 
     public keyboardType: KeyboardType;
     public returnKeyType: ReturnKeyType;
diff --git a/tns-core-modules/ui/editable-text-base/editable-text-base.android.ts b/tns-core-modules/ui/editable-text-base/editable-text-base.android.ts
@@ -77,6 +77,7 @@ function initializeEditTextListeners(): void {
                     clearTimeout(dismissKeyboardTimeoutId);
                     dismissKeyboardTimeoutId = undefined;
                 }
+                owner.notify({ eventName: EditableTextBase.focusEvent, object: owner });
             }
             else {
                 if (owner._dirtyTextAccumulator || owner._dirtyTextAccumulator === "") {
diff --git a/tns-core-modules/ui/editable-text-base/editable-text-base.d.ts b/tns-core-modules/ui/editable-text-base/editable-text-base.d.ts
@@ -9,6 +9,7 @@ import { TextBase, Property, CssProperty, Style, Color, FormattedString } from "
  */
 export class EditableTextBase extends TextBase {
     public static blurEvent: string;
+    public static focusEvent: string;
 
     /**
      * Gets or sets the soft keyboard type.
diff --git a/tns-core-modules/ui/text-field/text-field.ios.ts b/tns-core-modules/ui/text-field/text-field.ios.ts
@@ -33,6 +33,13 @@ class UITextFieldDelegateImpl extends NSObject implements UITextFieldDelegate {
         return true;
     }
 
+    public textFieldDidBeginEditing(textField: UITextField): void {
+        const owner = this._owner.get();
+        if (owner) {
+          owner.notify({ eventName: TextField.focusEvent, object: owner });
+        }
+    }
+
     public textFieldDidEndEditing(textField: UITextField) {
         const owner = this._owner.get();
         if (owner) {
diff --git a/tns-core-modules/ui/text-view/text-view.ios.ts b/tns-core-modules/ui/text-view/text-view.ios.ts
@@ -29,10 +29,11 @@ class UITextViewDelegateImpl extends NSObject implements UITextViewDelegate {
         return true;
     }
 
-    public textViewDidBeginEditing(textView: UITextView) {
-        var owner = this._owner.get();
+    public textViewDidBeginEditing(textView: UITextView): void {
+      const owner = this._owner.get();
         if (owner) {
             owner._isEditing = true;
+            owner.notify({ eventName: TextView.focusEvent, object: owner });
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,7 @@ function initializeEditTextListeners(): void {`
`77`	`77`	`clearTimeout(dismissKeyboardTimeoutId);`
`78`	`78`	`dismissKeyboardTimeoutId = undefined;`
`79`	`79`	`}`
	`80`	`+ owner.notify({ eventName: EditableTextBase.focusEvent, object: owner });`
`80`	`81`	`}`
`81`	`82`	`else {`
`82`	`83`	`if (owner._dirtyTextAccumulator \|\| owner._dirtyTextAccumulator === "") {`
Original file line number	Diff line number	Diff line change
`@@ -29,10 +29,11 @@ class UITextViewDelegateImpl extends NSObject implements UITextViewDelegate {`
`29`	`29`	`return true;`
`30`	`30`	`}`
`31`	`31`
`32`		`- public textViewDidBeginEditing(textView: UITextView) {`
`33`		`- var owner = this._owner.get();`
	`32`	`+ public textViewDidBeginEditing(textView: UITextView): void {`
	`33`	`+ const owner = this._owner.get();`
`34`	`34`	`if (owner) {`
`35`	`35`	`owner._isEditing = true;`
	`36`	`+ owner.notify({ eventName: TextView.focusEvent, object: owner });`
`36`	`37`	`}`
`37`	`38`	`}`
`38`	`39`