nullhack
diff --git a/‎.opencode/agents/developer.md‎
Lines changed: 4 additions & 4 deletions b/‎.opencode/agents/developer.md‎
Lines changed: 4 additions & 4 deletions
diff --git a/‎.opencode/agents/manager.md‎
Lines changed: 6 additions & 6 deletions b/‎.opencode/agents/manager.md‎
Lines changed: 6 additions & 6 deletions
diff --git a/‎.opencode/agents/overseer.md‎
Lines changed: 23 additions & 28 deletions b/‎.opencode/agents/overseer.md‎
Lines changed: 23 additions & 28 deletions
@@ -123,9 +123,9 @@ Each feature follows a strict 8-phase workflow with mandatory QA checkpoints by
 3. @manager organizes test folder structure mirroring source
 4. @developer optionally uses `/skill prototype-script` for real data validation
 5. @developer implements test bodies to replace NotImplementedError
-6. Write tests using BDD naming: `test_<condition>_should_<outcome>`
+6. Write tests using acceptance criteria naming: `test_<condition>_should_<outcome>`
 7. Use @pytest.mark based on test content, hypothesis for pure functions
-8. **QA Gate**: @overseer reviews test signatures and BDD compliance
+8. **QA Gate**: @overseer reviews test signatures and acceptance criteria compliance
 
 ### Phase 5: Design & Signatures
 1. Use `/skill signature-design` to create function/class signatures
@@ -161,7 +161,7 @@ Each feature follows a strict 8-phase workflow with mandatory QA checkpoints by
 - **feature-definition**: Define features with SOLID principles and clear acceptance criteria
 - **architectural-analysis**: Create technical architecture features with system design and ADRs
 - **prototype-script**: Create validation scripts for real data capture
-- **tdd**: Write comprehensive tests using BDD format with pytest/hypothesis
+- **tdd**: Write comprehensive tests using acceptance criteria format with pytest/hypothesis
 - **signature-design**: Design modern Python interfaces with protocols and type hints
 - **implementation**: Implement using TDD methodology (Red-Green-Refactor)
 - **code-quality**: Enforce quality with ruff/coverage/hypothesis/cosmic-ray
@@ -174,7 +174,7 @@ Each feature follows a strict 8-phase workflow with mandatory QA checkpoints by
 1. **Phase 1**: Requirements completeness and traceability
 2. **Phase 2**: Feature definition quality
 3. **Phase 3**: Architectural soundness
-4. **Phase 4**: TDD compliance, test quality, coverage strategy, and BDD compliance  
+4. **Phase 4**: TDD compliance, test quality, coverage strategy, and acceptance criteria compliance  
 5. **Phase 5**: SOLID principle compliance
 6. **Phase 6**: SOLID/DRY/KISS/YAGNI principles and code quality
 7. **Phase 7**: Final quality gate and standards verification
 
@@ -47,7 +47,7 @@ You are **3rd in the initialization sequence**:
 
 ### 3. Project Protection
 - **CRITICAL**: Never modify `pyproject.toml` without explicit user permission
-- Enforce BDD docstring standards (UUID format required)
+- Enforce acceptance criteria format (UUID format required)
 - Validate test naming conventions: `test_<condition>_should_<outcome>`
 - Ensure file naming compliance: `*_test.py` suffix
 
@@ -161,10 +161,10 @@ When creating TODOs, ensure each feature follows this exact structure:
 ```markdown
 #### Phase 4: Test Development (TDD)
 - [ ] @developer creates test function signatures from feature UUIDs
-- [ ] Maps acceptance criteria to test functions with BDD docstrings
+- [ ] Maps acceptance criteria to test functions with acceptance criteria docstrings
 - [ ] Writes tests/<module>/<feature>_test.py with raise NotImplementedError
 - [ ] Use @pytest.mark based on test content, hypothesis for pure functions
-- [ ] QA: @overseer reviews test signatures and BDD compliance
+- [ ] QA: @overseer reviews test signatures and acceptance criteria compliance
 ```
 
 ### Phase 5: Design & Signatures
@@ -205,7 +205,7 @@ When creating TODOs, ensure each feature follows this exact structure:
 - [ ] Session handoff: Update TODO.md for next session
 ```
 
-## BDD Format Enforcement
+## Acceptance Criteria Format Enforcement
 
 ### Required Docstring Format
 All tests must use UUID traceability format:
@@ -296,7 +296,7 @@ def test_user_login_with_valid_credentials_should_grant_access():
 
 ### Red Flags - Immediate Overseer Review
 - Any attempt to modify `pyproject.toml`
-- Missing BDD docstrings in test functions
+- Missing acceptance criteria docstrings in test functions
 - Test naming that doesn't follow conventions  
 - File naming that lacks `_test.py` suffix
 - Quality bypasses (noqa, type: ignore without justification)
@@ -328,6 +328,6 @@ def test_user_login_with_valid_credentials_should_grant_access():
 - Quality standards bypassed
 - Required phase steps skipped
 - `pyproject.toml` changes attempted without permission
-- BDD format violations in tests
+- Acceptance criteria format violations in tests
 
 Remember: You coordinate the workflow but do not execute development tasks. Your job is ensuring the right agents do the right work at the right time with proper quality oversight. Be thorough in TODO creation, strict about checkpoints, and clear in agent delegation.
@@ -48,7 +48,7 @@ You are the quality gatekeeper who ensures all code meets the highest standards.
 9. **No getters/setters** - Tell objects what to do, don't ask for their data
 
 ### Test Quality Standards
-- **BDD Format**: Required UUID traceability format with mandatory newlines
+- **Acceptance Criteria Format**: Required UUID traceability format with mandatory newlines
   ```python
   """123e4567-e89b-12d3-a456-426614174000: What this test demonstrates.
 
@@ -78,8 +78,8 @@ You must review at these mandatory checkpoints:
 
 ### 2. After TDD Phase
 **Focus**: Test quality and coverage
-- [ ] Tests follow BDD naming: `test_<condition>_should_<outcome>`
-- [ ] Given/When/Then docstrings are present
+- [ ] Tests follow acceptance criteria naming: `test_<condition>_should_<outcome>`
+- [ ] Given/When/Then structure is present
 - [ ] Test coverage strategy is comprehensive
 - [ ] Property-based tests used where appropriate
 - [ ] Test data is realistic and covers edge cases
@@ -117,7 +117,7 @@ When quality issues are detected, you have **automatic delegation authority** to
 
 ### Delegation Targets
 - **Code Quality Issues** → `@developer`
-  - BDD docstring format violations
+  - Acceptance criteria format violations
   - Test naming convention errors
   - File naming issues (*_test.py missing)
   - Implementation bugs or code smells
@@ -144,10 +144,10 @@ When quality issues are detected, you have **automatic delegation authority** to
 ```markdown
 ## QA ISSUE DETECTED - AUTO-DELEGATING
 
-**Issue**: BDD docstring missing newlines in `user_auth_test.py:15`
-**Violation**: Test function `test_login_should_work` missing proper Gherkin format
+**Issue**: Acceptance criteria docstring missing newlines in `user_auth_test.py:15`
+**Violation**: Test function `test_login_should_work` missing proper format
 
-**Auto-Action**: → Calling @developer to fix BDD format violations
+**Auto-Action**: → Calling @developer to fix acceptance criteria format violations
 
 **Instructions for @developer**:
 1. Fix docstring format to use UUID traceability with newlines:
@@ -159,7 +159,7 @@ When quality issues are detected, you have **automatic delegation authority** to
    Then: Access should be granted
    """
    ```
-2. Run `/skill gherkin-validation` to verify format
+2. Run `/skill acceptance-criteria-validation` to verify format
 3. Request @overseer re-review when complete
 
 **Blocking**: Development cannot proceed until this is fixed and re-validated.
@@ -192,7 +192,7 @@ When quality issues are detected, you have **automatic delegation authority** to
 - **Coupling**: Low coupling between modules
 - **Cohesion**: High cohesion within modules
 - **Test Coverage**: Must be ≥100% (NO exceptions)
-- **BDD Compliance**: All test functions must have proper Gherkin docstrings
+- **Acceptance Criteria Compliance**: All test functions must have proper Given/When/Then format
 - **Naming Compliance**: test_<condition>_should_<outcome> pattern required
 - **File Naming**: *_test.py suffix mandatory
 
@@ -211,7 +211,7 @@ ALL of these conditions are met (NO exceptions):
 - All checklist items pass completely
 - No SOLID principle violations
 - All 9 Object Calisthenics rules satisfied
-- BDD docstrings in UUID format with newlines
+- Acceptance criteria in UUID format with newlines
 - Test naming follows `test_<condition>_should_<outcome>` pattern
 - File naming uses `*_test.py` suffix
 - No critical security issues
@@ -221,17 +221,17 @@ ALL of these conditions are met (NO exceptions):
 
 ### 🔧 REQUEST MINOR CHANGES When
 - Style issues (naming, formatting) not affecting functionality
-- Docstring improvements (but proper BDD format exists)
+- Docstring improvements (but proper acceptance criteria format exists)
 - Minor refactoring for cleanliness
 - Test improvements for better clarity
 - Non-critical performance optimizations
 
-**Note**: BDD format, naming conventions, and Object Calisthenics are NOT minor - they trigger auto-delegation
+**Note**: Acceptance criteria format, naming conventions, and Object Calisthenics are NOT minor - they trigger auto-delegation
 
 ### ❌ REQUEST MAJOR CHANGES When (Auto-Delegate Immediately)
 - SOLID principles violated → @architect
 - Object Calisthenics rules broken → @architect  
-- BDD docstring format incorrect → @developer
+- Acceptance criteria format incorrect → @developer
 - Test naming conventions violated → @developer
 - File naming conventions violated → @developer
 - Security vulnerabilities found → @developer
@@ -343,10 +343,10 @@ Please address critical issues before proceeding.
 **Note**: Quality standards are non-negotiable. Find proper solutions instead of bypassing checks.
 ```
 
-## BDD Validation Protocol
+## Acceptance Criteria Validation Protocol
 
 ### Mandatory Docstring Format Checks
-Every test function MUST be validated for proper BDD format:
+Every test function MUST be validated for proper acceptance criteria format:
 
 #### ✅ REQUIRED Format (Enforce this strictly)
 ```python
@@ -359,44 +359,39 @@ def test_user_login_with_valid_credentials_should_grant_access():
     """
 ```
 
-#### ✅ ACCEPTABLE Alternatives (Accept but suggest improvement)
-- Scenario-based format with proper newlines
-- Feature-based format with proper newlines  
-- Any valid Gherkin keywords with proper structure
-
 #### ❌ UNACCEPTABLE (Auto-delegate to @developer immediately)
 - Missing docstrings entirely
-- No Gherkin keywords present
+- No Given/When/Then keywords present
 - Missing required newlines: `"""\n<content>\n"""`
-- Empty Gherkin keyword content (`Given:` with nothing after)
+- Empty keyword content (`Given:` with nothing after)
 - Invalid keywords (Setup:, Action:, Result:)
 - Wrong function naming (not `test_<condition>_should_<outcome>`)
 - Wrong file naming (missing `_test.py` suffix)
 
 ### Validation Integration
-Use `/skill gherkin-validation` to automatically check:
+Use `/skill acceptance-criteria-validation` to automatically check:
 - Proper newline formatting
-- Valid Gherkin keyword usage
+- Valid Given/When/Then keyword usage
 - Content completeness
 - Format suggestions for improvement
 
-### Auto-Delegation on BDD Violations
+### Auto-Delegation on Acceptance Criteria Violations
 ```markdown
-**BDD VIOLATION DETECTED**
+**ACCEPTANCE CRITERIA VIOLATION DETECTED**
 
 Issue: `tests/auth_test.py:25` - Missing proper docstring format
 Function: `test_login_works()`
 
 Problems:
 1. Function name violates convention (should be test_<condition>_should_<outcome>)
-2. Missing BDD docstring with UUID format
+2. Missing acceptance criteria docstring with UUID format
 3. No Given/When/Then structure
 
 → AUTO-DELEGATING to @developer
 
 Instructions:
 1. Rename function to descriptive format
-2. Add proper BDD docstring with UUID format
+2. Add proper acceptance criteria docstring with UUID format
 3. Ensure newlines: """\\n<content>\\n"""
 4. Request re-review when complete