From 8504a8fcc5ba436c76b38b43cbb2e3f207124659 Mon Sep 17 00:00:00 2001 From: Luke Page Date: Wed, 30 Jan 2019 08:24:05 +0100 Subject: [PATCH 1/2] Fix exceptions occurring in 2.4.2 As per comments here: https://github.com/npm/write-file-atomic/commit/3365a4df7d6117473905ec3f633d9a1bb42b6b17 jest is unusable with the latest version. --- index.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/index.js b/index.js index 3eef78a..93d8677 100644 --- a/index.js +++ b/index.js @@ -224,7 +224,11 @@ function writeFileSync (filename, data, options) { fs.renameSync(tmpfile, filename) removeOnExitHandler() } catch (err) { - if (fd) fs.closeSync(fd) + if (fd) { + try { + fs.closeSync(fd) + } catch(e) {} + } removeOnExitHandler() cleanup() throw err From 5cb9dd72e0868c832fac5da4c0a17fa3d0af8a10 Mon Sep 17 00:00:00 2001 From: Rebecca Turner Date: Mon, 4 Feb 2019 10:17:00 -0800 Subject: [PATCH 2/2] Update index.js --- index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/index.js b/index.js index 93d8677..64ae987 100644 --- a/index.js +++ b/index.js @@ -227,7 +227,9 @@ function writeFileSync (filename, data, options) { if (fd) { try { fs.closeSync(fd) - } catch(e) {} + } catch (ex) { + // ignore close errors at this stage, error may have closed fd already. + } } removeOnExitHandler() cleanup()